From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932735AbeEHOrN (ORCPT ); Tue, 8 May 2018 10:47:13 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:59436 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932706AbeEHOrJ (ORCPT ); Tue, 8 May 2018 10:47:09 -0400 Subject: Re: [PATCH 01/11] irqchip: stm32: Optimizes and cleans up stm32-exti irq_domain To: Ludovic Barre , Thomas Gleixner , Jason Cooper , Rob Herring Cc: Maxime Coquelin , Alexandre Torgue , Gerald BAEZA , Loic PALLARDY , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, radek References: <1524759514-12392-1-git-send-email-ludovic.Barre@st.com> <1524759514-12392-2-git-send-email-ludovic.Barre@st.com> From: Marc Zyngier Organization: ARM Ltd Message-ID: <20a1b5f0-7494-01a9-635f-c46c337a23b3@arm.com> Date: Tue, 8 May 2018 15:47:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1524759514-12392-2-git-send-email-ludovic.Barre@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/04/18 17:18, Ludovic Barre wrote: > From: radek > > - In stm32_exti_alloc function, discards irq_domain_set_info > with handle_simple_irq. This overwrite the setting defined while init > of generic chips. Exti controller manages edge irq type. > - Removes acking in chained irq handler as this is done by > irq_chip itself inside handle_edge_irq > - removes unneeded irq_domain_ops.xlate callback > > Signed-off-by: Radoslaw Pietrzyk > Acked-by: Ludovic Barre > Tested-by: Ludovic Barre > Signed-off-by: Ludovic Barre Nit: the "From:" should match the SoB line (the address does, but not the name). I can fix that up when I apply the series. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Tue, 8 May 2018 15:47:04 +0100 Subject: [PATCH 01/11] irqchip: stm32: Optimizes and cleans up stm32-exti irq_domain In-Reply-To: <1524759514-12392-2-git-send-email-ludovic.Barre@st.com> References: <1524759514-12392-1-git-send-email-ludovic.Barre@st.com> <1524759514-12392-2-git-send-email-ludovic.Barre@st.com> Message-ID: <20a1b5f0-7494-01a9-635f-c46c337a23b3@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 26/04/18 17:18, Ludovic Barre wrote: > From: radek > > - In stm32_exti_alloc function, discards irq_domain_set_info > with handle_simple_irq. This overwrite the setting defined while init > of generic chips. Exti controller manages edge irq type. > - Removes acking in chained irq handler as this is done by > irq_chip itself inside handle_edge_irq > - removes unneeded irq_domain_ops.xlate callback > > Signed-off-by: Radoslaw Pietrzyk > Acked-by: Ludovic Barre > Tested-by: Ludovic Barre > Signed-off-by: Ludovic Barre Nit: the "From:" should match the SoB line (the address does, but not the name). I can fix that up when I apply the series. Thanks, M. -- Jazz is not dead. It just smells funny...