From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81378C433E0 for ; Fri, 15 May 2020 04:23:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B37C206F4 for ; Fri, 15 May 2020 04:23:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="pMcZxToO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726504AbgEOEXm (ORCPT ); Fri, 15 May 2020 00:23:42 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:15879 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbgEOEXm (ORCPT ); Fri, 15 May 2020 00:23:42 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589516622; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=fcotPRDneqlOpcVfqWQi9yd9jerMS3v05oGvbu+gO4g=; b=pMcZxToOFz4u03HHw/OsiFGBiWlXyydeVEI3DrZ0xoEWve0yIVuDUILmVu02oLncUt2IERlm Hca7vONhh2lcRpRRDBZg/pm6lOB1/p6PYeEWo71Fl4F+vRBZfFtUHryfc0M9lkTjtdcx+jrV XwD4EQ44MzUJE08VBMTQoqDj3zE= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5ebe193daefa5a01ccbdc2fe (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 15 May 2020 04:23:25 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AF71EC432C2; Fri, 15 May 2020 04:23:24 +0000 (UTC) Received: from [192.168.1.7] (unknown [122.169.155.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgautam) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5F58FC433D2; Fri, 15 May 2020 04:23:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5F58FC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org Subject: Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver To: Viresh Kumar , Georgi Djakov Cc: Matthias Kaehlcke , Felipe Balbi , Sandeep Maheswaram , Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Mark Rutland , Stephen Boyd , Doug Anderson , "linux-arm-msm@vger.kernel.org" , "open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" , "devicetree@vger.kernel.org" , Linux Kernel Mailing List , Chandana Kishori Chiluveru References: <1585718145-29537-1-git-send-email-sanm@codeaurora.org> <1585718145-29537-3-git-send-email-sanm@codeaurora.org> <878shu4uwk.fsf@kernel.org> <875zcy4uuj.fsf@kernel.org> <20200514171352.GP4525@google.com> From: Manu Gautam Message-ID: <20a2adc5-4153-1447-0542-908b7996c187@codeaurora.org> Date: Fri, 15 May 2020 09:53:15 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On 5/15/2020 9:27 AM, Viresh Kumar wrote: > On Fri, 15 May 2020 at 02:33, Georgi Djakov wrote: > >> ---8<--- >> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig >> index 206caa0ea1c6..6661788b1a76 100644 >> --- a/drivers/usb/dwc3/Kconfig >> +++ b/drivers/usb/dwc3/Kconfig >> @@ -129,6 +129,7 @@ config USB_DWC3_QCOM >> tristate "Qualcomm Platform" >> depends on ARCH_QCOM || COMPILE_TEST >> depends on EXTCON || !EXTCON >> + depends on INTERCONNECT || !INTERCONNECT > Again, as I said yesterday. This looks incorrect and may not fix the problem.. > > With this we will be able to select USB_DWC3_QCOM even when INTERCONNECT=m. DWC3_QCOM in that case would be 'm' if INTERCONNECT =m and that should be fine? > What we perhaps need here is: > depends on INTERCONNECT != m > > -- > viresh -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project