From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 392E6C433EF for ; Thu, 13 Jan 2022 13:29:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1C71F832DA; Thu, 13 Jan 2022 14:29:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="nAiytrHO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4E6D283264; Thu, 13 Jan 2022 14:29:53 +0100 (CET) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E73A3832DA for ; Thu, 13 Jan 2022 14:29:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 5338C2223B; Thu, 13 Jan 2022 14:29:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1642080590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s8HWW7g37EOF5Bs1oVTy0xgn8M1aq2VcUwQdqkvQylo=; b=nAiytrHODP8sw3UAeIqkFTX10rcWb3BFGCoZyKuSqld3UI6CcUnwbrf67fI6ecKhKWCSOx SVZvbLLOu8fjK8QgJQ+DTOC4QTnq7/igRorVL/PqHm7hnmrLUAX/MKVQaSZop1eT6a/Cbg vcAB/3xTqOgQbebhZDgXFY4ksgXj66s= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 13 Jan 2022 14:29:50 +0100 From: Michael Walle To: Patrick Wildt Cc: festevam@denx.de, frieder.schrempf@kontron.de, heiko.thiery@gmail.com, hs@denx.de, marcel.ziswiler@toradex.com, peng.fan@oss.nxp.com, sbabic@denx.de, trini@konsulko.com, u-boot@lists.denx.de Subject: Re: [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name In-Reply-To: References: <20220113114250.2656319-1-michael@walle.cc> User-Agent: Roundcube Webmail/1.4.12 Message-ID: <20a6a4f25750fa6760f18079b684aee2@walle.cc> X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Am 2022-01-13 14:16, schrieb Patrick Wildt: > On Thu, Jan 13, 2022 at 12:42:50PM +0100, Michael Walle wrote: >> Hi, >> >> > --- a/arch/arm/dts/imx8mm-u-boot.dtsi >> > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi >> > @@ -39,7 +39,7 @@ >> > filename = "u-boot-spl.bin"; >> > }; >> > >> > - 1d-imem { >> > + 1d_imem { >> >> I think it is the other way around. Device tree node names should >> contain >> hyphens and not underscores. >> >> I couldn't find any references in dtschema though. Maybe I haven't >> looked >> hard enough. >> >> But you can see linux commit 28d7f0f3f10b, for example. >> >> -michael > > Hi, > > I don't know what's right, but every other of these in the i.MX8MM file > use _ instead of -, so if at all this makes it consistenly wrong, but > at least now it's consistent. ;) > > If it's wrong, I'm sure someone will step up and rectify it. Why don't you just change it to the correct naming then? -michael