From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5970CC4332F for ; Fri, 21 Oct 2022 03:28:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230052AbiJUD2N (ORCPT ); Thu, 20 Oct 2022 23:28:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbiJUD1w (ORCPT ); Thu, 20 Oct 2022 23:27:52 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C006B1EEA16; Thu, 20 Oct 2022 20:27:45 -0700 (PDT) X-UUID: b0300b9995a94ef0ae0a5f763a699ed1-20221021 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=liRN+HmxoIKuY83k0B956REc4h3T4bcOVKQySzS8Z7g=; b=TtpGlCVMq3Zes+NBDYyLEj22qgKyjATJni/4fRyQ/e6MjRcLUhLFEd3QoDNG/uf7oquQMHuWiVFeIFsuDFeztOrhVW0jnMzi4x91elDV6+lYwWfY1YD3Y7MeeZ6ZmmQo8DTKu+fsCj2WPSf5TLbavBtc/TSiWcAoQ8p3UoKd7QY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.12,REQID:c26f921f-6ab4-4340-9133-22503ddb52dc,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:51,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:51 X-CID-INFO: VERSION:1.1.12,REQID:c26f921f-6ab4-4340-9133-22503ddb52dc,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:51,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:51 X-CID-META: VersionHash:62cd327,CLOUDID:fbb839c8-03ab-4171-989e-341ab5339257,B ulkID:2210211026516FV6XUSA,BulkQuantity:8,Recheck:0,SF:38|28|17|19|48|102, TC:nil,Content:0,EDM:-3,IP:nil,URL:11|1,File:nil,Bulk:40,QS:nil,BEC:nil,CO L:0 X-UUID: b0300b9995a94ef0ae0a5f763a699ed1-20221021 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 104753269; Fri, 21 Oct 2022 11:27:37 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 21 Oct 2022 11:27:35 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 21 Oct 2022 11:27:34 +0800 Message-ID: <20a87e771e4bcce4e9c9f0a1db13e20f75ce3b72.camel@mediatek.com> Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: mediatek-gen3: Support mt8195 From: Jianjun Wang To: Rob Herring , Tinghan Shen CC: Ryder Lee , Bjorn Helgaas , Krzysztof Kozlowski , Matthias Brugger , , , , , , Date: Fri, 21 Oct 2022 11:27:33 +0800 In-Reply-To: <20221021022647.GA2195154-robh@kernel.org> References: <20221020111925.30002-1-tinghan.shen@mediatek.com> <20221020111925.30002-2-tinghan.shen@mediatek.com> <20221021022647.GA2195154-robh@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thanks for your review. On Thu, 2022-10-20 at 21:26 -0500, Rob Herring wrote: > On Thu, Oct 20, 2022 at 07:19:23PM +0800, Tinghan Shen wrote: > > From: Jianjun Wang > > > > In order to support mt8195 pcie node, update the yaml to support > > new > > properties of iommu and power-domain, and update the reset-names > > property to allow only one 'mac' name. > > > > Signed-off-by: Jianjun Wang > > Signed-off-by: TingHan Shen > > --- > > .../bindings/pci/mediatek-pcie-gen3.yaml | 16 > > +++++++++++++--- > > 1 file changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie- > > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie- > > gen3.yaml > > index c00be39af64e..af271018b134 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > @@ -70,14 +70,21 @@ properties: > > minItems: 1 > > maxItems: 8 > > > > + iommu-map: > > + maxItems: 1 > > + > > + iommu-map-mask: > > + maxItems: 1 > > This is not a array. It needs a value. Must be 0 if iommu-map only > has 1 > entry? Or you only support 1 downstream device? We only has 1 entry for iommu-map, we'll change it to 0 in the next version. Thanks. > > > + > > resets: > > minItems: 1 > > maxItems: 2 > > > > reset-names: > > - minItems: 1 > > - items: > > - - const: phy > > + oneOf: > > + - items: > > + - const: phy > > + - const: mac > > - const: mac > > > > clocks: > > @@ -107,6 +114,9 @@ properties: > > items: > > - const: pcie-phy > > > > + power-domains: > > + maxItems: 1 > > + > > '#interrupt-cells': > > const: 1 > > > > -- > > 2.18.0 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89F33C4332F for ; Fri, 21 Oct 2022 03:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DdDfcmorWW5kT1rThhz6qRO+KwV5Ro8kD7YsVRStvgA=; b=piMIaz5oKyzab7 Eqo8S/NcEtDDcEr45izuNZ0+nEi4gvkHTmCKp83Bc25bBsowi/QWvNhI6I5P9k3UEXKJb7wT+Wtqy ZYzfCeOdayEG5X7nf+7NSihpK+JhjqmToC4ILUnIrHGhbaE89FaUKaYKbmwmRYRvHuzMyGpza+T/g SW1zcSSIQlzSLzFtuMBWqwtQ/+s6moQc3prS8C8abmTbPCnMKwjfGcZxCvTEKBKXm57X6JwyBTy4V +QLcybXDXXm3WOc8p5S4OmiNpSKjS4iUv3839dy+0GvcFtC1oYPjEPNWyjnRYXot1NBeHbSObLTQY afarKFR/G3ClX6lB2S9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olihn-004lND-Cm; Fri, 21 Oct 2022 03:28:19 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olihl-004lKI-2c; Fri, 21 Oct 2022 03:28:18 +0000 X-UUID: fa0d5d5609fd4595bf0d0cd6667cddb3-20221020 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=liRN+HmxoIKuY83k0B956REc4h3T4bcOVKQySzS8Z7g=; b=TtpGlCVMq3Zes+NBDYyLEj22qgKyjATJni/4fRyQ/e6MjRcLUhLFEd3QoDNG/uf7oquQMHuWiVFeIFsuDFeztOrhVW0jnMzi4x91elDV6+lYwWfY1YD3Y7MeeZ6ZmmQo8DTKu+fsCj2WPSf5TLbavBtc/TSiWcAoQ8p3UoKd7QY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.12,REQID:44f0a5b2-9434-4778-9dfd-626bd224a3d0,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:62cd327,CLOUDID:fabd35e4-e572-4957-be22-d8f73f3158f9,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: fa0d5d5609fd4595bf0d0cd6667cddb3-20221020 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 360472238; Thu, 20 Oct 2022 20:28:09 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 21 Oct 2022 11:27:35 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 21 Oct 2022 11:27:34 +0800 Message-ID: <20a87e771e4bcce4e9c9f0a1db13e20f75ce3b72.camel@mediatek.com> Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: mediatek-gen3: Support mt8195 From: Jianjun Wang To: Rob Herring , Tinghan Shen CC: Ryder Lee , Bjorn Helgaas , Krzysztof Kozlowski , Matthias Brugger , , , , , , Date: Fri, 21 Oct 2022 11:27:33 +0800 In-Reply-To: <20221021022647.GA2195154-robh@kernel.org> References: <20221020111925.30002-1-tinghan.shen@mediatek.com> <20221020111925.30002-2-tinghan.shen@mediatek.com> <20221021022647.GA2195154-robh@kernel.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_202817_181214_7BC151CD X-CRM114-Status: GOOD ( 21.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Thanks for your review. On Thu, 2022-10-20 at 21:26 -0500, Rob Herring wrote: > On Thu, Oct 20, 2022 at 07:19:23PM +0800, Tinghan Shen wrote: > > From: Jianjun Wang > > > > In order to support mt8195 pcie node, update the yaml to support > > new > > properties of iommu and power-domain, and update the reset-names > > property to allow only one 'mac' name. > > > > Signed-off-by: Jianjun Wang > > Signed-off-by: TingHan Shen > > --- > > .../bindings/pci/mediatek-pcie-gen3.yaml | 16 > > +++++++++++++--- > > 1 file changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie- > > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie- > > gen3.yaml > > index c00be39af64e..af271018b134 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > @@ -70,14 +70,21 @@ properties: > > minItems: 1 > > maxItems: 8 > > > > + iommu-map: > > + maxItems: 1 > > + > > + iommu-map-mask: > > + maxItems: 1 > > This is not a array. It needs a value. Must be 0 if iommu-map only > has 1 > entry? Or you only support 1 downstream device? We only has 1 entry for iommu-map, we'll change it to 0 in the next version. Thanks. > > > + > > resets: > > minItems: 1 > > maxItems: 2 > > > > reset-names: > > - minItems: 1 > > - items: > > - - const: phy > > + oneOf: > > + - items: > > + - const: phy > > + - const: mac > > - const: mac > > > > clocks: > > @@ -107,6 +114,9 @@ properties: > > items: > > - const: pcie-phy > > > > + power-domains: > > + maxItems: 1 > > + > > '#interrupt-cells': > > const: 1 > > > > -- > > 2.18.0 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel