From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D8FEC433EF for ; Sat, 21 May 2022 09:43:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242239AbiEUJn5 (ORCPT ); Sat, 21 May 2022 05:43:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230156AbiEUJnz (ORCPT ); Sat, 21 May 2022 05:43:55 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 11CAF5C350 for ; Sat, 21 May 2022 02:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653126233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dQakkrlXQRKntd0RRpdtvvmaPsTow/BNKvunF/X2S4o=; b=BUzq2G6otepKopPlpL9EiTi7ksSsjFF3i5lcQC2ANvTyujXojQLQ7tHvNVlRCxrrAWwFZ3 SoAnk2WGy3+iyrK03PmVSQTOIY5pxoDbBSM/kRUk4nhPvPMNhTJTjeK5/Aq5mCMiv6CFOg q1G7nvUV1rQ5HydYv0JMfPo3t75XwEs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-427-ClIMAF1ZOIeX1NgWfqYz4A-1; Sat, 21 May 2022 05:43:51 -0400 X-MC-Unique: ClIMAF1ZOIeX1NgWfqYz4A-1 Received: by mail-wr1-f72.google.com with SMTP id x4-20020a5d4444000000b0020d130e8a36so3104114wrr.9 for ; Sat, 21 May 2022 02:43:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dQakkrlXQRKntd0RRpdtvvmaPsTow/BNKvunF/X2S4o=; b=rPnTAmFWm12O38fUpQ9b0xCYLmh0pqAxnZxgeu9prb0T1+6h5HXBU4UwGvKW88uZAU gELgqlUFY3NhPKSMA3Pvlo0TVzfA35ZPNTGOTEv+/OeaqVxBYgXbsIU201lX2yYQkd6D QaDAIWTVYroZyig1RwfbQt1R9wBcBaXGfvQcQfjlB3t/2atrxnctm2bTNK2eTKmbRCnz MhwiR3QRl833ULweTIF1BoSWvRCXPPni8tPdyDLM/RCrgB+z170SiagMJRSPlL92qTQl 8tPfIjUwDlqM8bCBnmGRJIAN9Dozqu2vlbM797ZBwoRM0SFL87UORwKiYmix0Ifv4DyB 3PtQ== X-Gm-Message-State: AOAM530eKJzkM81gnDRw7uWGaLF+PZvWeTrlV3kY2f+zfqSF0tf0OzUZ 61ruvXWjPCPEjimZ8PIHiKSiEikbPrhwXwXmhp49sLeE32DMiH6uEWLK4NkfN6jdBOX30ZEXM97 pUL6k199FOhMLpcr5HgcP9TPo X-Received: by 2002:a05:6000:144e:b0:20e:6719:c376 with SMTP id v14-20020a056000144e00b0020e6719c376mr11371522wrx.715.1653126230196; Sat, 21 May 2022 02:43:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNY4l0J3NU0fU5ldjpTVsJKjUF0HOYrRkkJ7veXmwkg/db0qArtoiGUueey/Ksa0YlGIw9oQ== X-Received: by 2002:a05:6000:144e:b0:20e:6719:c376 with SMTP id v14-20020a056000144e00b0020e6719c376mr11371508wrx.715.1653126229992; Sat, 21 May 2022 02:43:49 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id d21-20020adf9b95000000b0020d06e7c16fsm4529325wrc.84.2022.05.21.02.43.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 May 2022 02:43:49 -0700 (PDT) Message-ID: <20bde9a2-592d-30a8-8cdc-03bdf1bf3e93@redhat.com> Date: Sat, 21 May 2022 11:43:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V11 09/22] LoongArch: Add boot and setup routines Content-Language: en-US To: Huacai Chen Cc: Ard Biesheuvel , Huacai Chen , Arnd Bergmann , Andy Lutomirski , Thomas Gleixner , Peter Zijlstra , Andrew Morton , David Airlie , Jonathan Corbet , Linus Torvalds , linux-arch , Linux Doc Mailing List , Linux Kernel Mailing List , Xuefeng Li , Yanteng Si , Guo Ren , Xuerui Wang , Jiaxun Yang , Stephen Rothwell , linux-efi References: <20220518092619.1269111-1-chenhuacai@loongson.cn> <20220518092619.1269111-10-chenhuacai@loongson.cn> <0bae0df1-48ae-d02f-bce4-d1f69acf269e@redhat.com> <256e0b82-5d0f-cf40-87c6-c2505d2a6d3b@redhat.com> <859d5489-9361-3db0-1da4-1417ed2fad6c@redhat.com> <7caec251-20e7-4a8c-93ee-b28558ec580f@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Huacai, On 5/21/22 11:13, Huacai Chen wrote: > Hi, Javier, > > On Sat, May 21, 2022 at 5:06 PM Javier Martinez Canillas > wrote: >> >> Hello Huacai, >> >> On 5/21/22 09:37, Huacai Chen wrote: >> >> [snip] >> >>>> >>>> A problem with moving to subsys_initcall_sync() is that this will delay >>>> more when a display is available in the system, and just to cope up with >>>> a corner case (as mentioned the common case is native drivers as module). >>> OK, your method seems better, but I think moving to >>> subsys_initcall_sync() can make the screen display as early as >>> possible. >>> >> >> But it doesn't cover all cases. For example, you will get the same error >> if for example your native driver is built-in and efifb built as module. >> >> So my opinion is that instead of playing with the init call levels, is >> just better for you to build your native driver as a module instead of >> making it built-in. > I mean moving to subsys_initcall_sync() on top of your patchset, not > replacing them (Just for display earlier). > Ah, I see what you mean. Yes, that makes sense indeed. Feel free to post a patch proposing that. If you do, please also include Thomas Zimmermann to the Cc list. Thanks! -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat