[Intel-wired-lan] [net-next, v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error

[Intel-wired-lan] [net-next, v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error

[Hao Chen]

After I turn on the CONFIG_LOCK_STAT=y, insmod e1000e.ko will report:
[    5.641579] e1000e: Unknown symbol mutex_lock (err -2)
[   90.775705] e1000e: Unknown symbol mutex_lock (err -2)
[  132.252339] e1000e: Unknown symbol mutex_lock (err -2)

This problem fixed after include <linux/mutex.h>.

Signed-off-by: Hao Chen <chenhaoa@uniontech.com>
---
 drivers/net/ethernet/intel/e1000e/e1000.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h b/drivers/net/ethernet/intel/e1000e/e1000.h
index 5b2143f4b1f8..f3424255bd2b 100644
--- a/drivers/net/ethernet/intel/e1000e/e1000.h
+++ b/drivers/net/ethernet/intel/e1000e/e1000.h
@@ -21,6 +21,7 @@
 #include <linux/ptp_classify.h>
 #include <linux/mii.h>
 #include <linux/mdio.h>
+#include <linux/mutex.h>
 #include <linux/pm_qos.h>
 #include "hw.h"
 
-- 
2.20.1

Re: [net-next,v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error

[Jesse Brandeburg]

On 9/17/2021 7:11 AM, Hao Chen wrote:
> After I turn on the CONFIG_LOCK_STAT=y, insmod e1000e.ko will report:
> [    5.641579] e1000e: Unknown symbol mutex_lock (err -2)
> [   90.775705] e1000e: Unknown symbol mutex_lock (err -2)
> [  132.252339] e1000e: Unknown symbol mutex_lock (err -2)
> 
> This problem fixed after include <linux/mutex.h>.

Thanks for taking the time to send a patch.
Why do you think including a file will fix this? That error is usually
the user's fault for trying to use insmod which doesn't check module
dependencies.

The advice I usually give is to try modprobe instead, does the problem
still occur without this patch and just using modprobe?

[Intel-wired-lan] [net-next, v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error

[Jesse Brandeburg]

On 9/17/2021 7:11 AM, Hao Chen wrote:
> After I turn on the CONFIG_LOCK_STAT=y, insmod e1000e.ko will report:
> [    5.641579] e1000e: Unknown symbol mutex_lock (err -2)
> [   90.775705] e1000e: Unknown symbol mutex_lock (err -2)
> [  132.252339] e1000e: Unknown symbol mutex_lock (err -2)
> 
> This problem fixed after include <linux/mutex.h>.

Thanks for taking the time to send a patch.
Why do you think including a file will fix this? That error is usually
the user's fault for trying to use insmod which doesn't check module
dependencies.

The advice I usually give is to try modprobe instead, does the problem
still occur without this patch and just using modprobe?

[net-next,v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error

[Hao Chen]

After I turn on the CONFIG_LOCK_STAT=y, insmod e1000e.ko will report:
[    5.641579] e1000e: Unknown symbol mutex_lock (err -2)
[   90.775705] e1000e: Unknown symbol mutex_lock (err -2)
[  132.252339] e1000e: Unknown symbol mutex_lock (err -2)

This problem fixed after include <linux/mutex.h>.

Signed-off-by: Hao Chen <chenhaoa@uniontech.com>
---
 drivers/net/ethernet/intel/e1000e/e1000.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h b/drivers/net/ethernet/intel/e1000e/e1000.h
index 5b2143f4b1f8..f3424255bd2b 100644
--- a/drivers/net/ethernet/intel/e1000e/e1000.h
+++ b/drivers/net/ethernet/intel/e1000e/e1000.h
@@ -21,6 +21,7 @@
 #include <linux/ptp_classify.h>
 #include <linux/mii.h>
 #include <linux/mdio.h>
+#include <linux/mutex.h>
 #include <linux/pm_qos.h>
 #include "hw.h"
 
-- 
2.20.1

Re: [net-next,v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 17 Sep 2021 14:16:54 +0000 you wrote:
> After I turn on the CONFIG_LOCK_STAT=y, insmod e1000e.ko will report:
> [    5.641579] e1000e: Unknown symbol mutex_lock (err -2)
> [   90.775705] e1000e: Unknown symbol mutex_lock (err -2)
> [  132.252339] e1000e: Unknown symbol mutex_lock (err -2)
> 
> This problem fixed after include <linux/mutex.h>.
> 
> [...]

Here is the summary with links:
  - [net-next,v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error
    https://git.kernel.org/netdev/net-next/c/6042d4348a34

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html