From: Paolo Bonzini <pbonzini@redhat.com>
To: Marc Zyngier <maz@kernel.org>, kvm@vger.kernel.org
Cc: kernel-team@android.com, Andrew Jones <drjones@redhat.com>,
Ricardo Koller <ricarkol@google.com>
Subject: Re: [PATCH] KVM: selftests: x86: Address missing vm_install_exception_handler conversions
Date: Thu, 8 Jul 2021 18:52:00 +0200 [thread overview]
Message-ID: <20cdb930-a1d9-058b-4317-e851ede02470@redhat.com> (raw)
In-Reply-To: <20210701071928.2971053-1-maz@kernel.org>
On 01/07/21 09:19, Marc Zyngier wrote:
> Commit b78f4a59669 ("KVM: selftests: Rename vm_handle_exception")
> raced with a couple of new x86 tests, missing two vm_handle_exception
> to vm_install_exception_handler conversions.
>
> Help the two broken tests to catch up with the new world.
>
> Cc: Andrew Jones <drjones@redhat.com>
> CC: Ricardo Koller <ricarkol@google.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> tools/testing/selftests/kvm/x86_64/hyperv_features.c | 2 +-
> tools/testing/selftests/kvm/x86_64/mmu_role_test.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_features.c b/tools/testing/selftests/kvm/x86_64/hyperv_features.c
> index 42bd658f52a8..af27c7e829c1 100644
> --- a/tools/testing/selftests/kvm/x86_64/hyperv_features.c
> +++ b/tools/testing/selftests/kvm/x86_64/hyperv_features.c
> @@ -615,7 +615,7 @@ int main(void)
>
> vm_init_descriptor_tables(vm);
> vcpu_init_descriptor_tables(vm, VCPU_ID);
> - vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);
> + vm_install_exception_handler(vm, GP_VECTOR, guest_gp_handler);
>
> pr_info("Testing access to Hyper-V specific MSRs\n");
> guest_test_msrs_access(vm, addr_gva2hva(vm, msr_gva),
> diff --git a/tools/testing/selftests/kvm/x86_64/mmu_role_test.c b/tools/testing/selftests/kvm/x86_64/mmu_role_test.c
> index 523371cf8e8f..da2325fcad87 100644
> --- a/tools/testing/selftests/kvm/x86_64/mmu_role_test.c
> +++ b/tools/testing/selftests/kvm/x86_64/mmu_role_test.c
> @@ -71,7 +71,7 @@ static void mmu_role_test(u32 *cpuid_reg, u32 evil_cpuid_val)
> /* Set up a #PF handler to eat the RSVD #PF and signal all done! */
> vm_init_descriptor_tables(vm);
> vcpu_init_descriptor_tables(vm, VCPU_ID);
> - vm_handle_exception(vm, PF_VECTOR, guest_pf_handler);
> + vm_install_exception_handler(vm, PF_VECTOR, guest_pf_handler);
>
> r = _vcpu_run(vm, VCPU_ID);
> TEST_ASSERT(r == 0, "vcpu_run failed: %d\n", r);
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2021-07-08 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 7:19 [PATCH] KVM: selftests: x86: Address missing vm_install_exception_handler conversions Marc Zyngier
2021-07-01 7:30 ` Andrew Jones
2021-07-01 17:29 ` Ricardo Koller
2021-07-08 16:52 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20cdb930-a1d9-058b-4317-e851ede02470@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=ricarkol@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.