From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Tadeusz Struk <tadeusz.struk@linaro.org>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
stable@vger.kernel.org,
syzbot+f9f76f4a0766420b4a02@syzkaller.appspotmail.com
Subject: Re: [PATCH] nfc: fix segfault in nfc_genl_dump_devices_done
Date: Thu, 9 Dec 2021 09:12:12 +0100 [thread overview]
Message-ID: <20dcbf40-0ca0-690d-182a-e21ee6af1db4@canonical.com> (raw)
In-Reply-To: <20211208182742.340542-1-tadeusz.struk@linaro.org>
On 08/12/2021 19:27, Tadeusz Struk wrote:
> When kmalloc in nfc_genl_dump_devices() fails then
> nfc_genl_dump_devices_done() segfaults as below
>
> KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]
> CPU: 0 PID: 25 Comm: kworker/0:1 Not tainted 5.16.0-rc4-01180-g2a987e65025e-dirty #5
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-6.fc35 04/01/2014
> Workqueue: events netlink_sock_destruct_work
> RIP: 0010:klist_iter_exit+0x26/0x80
> Call Trace:
> <TASK>
> class_dev_iter_exit+0x15/0x20
> nfc_genl_dump_devices_done+0x3b/0x50
> genl_lock_done+0x84/0xd0
> netlink_sock_destruct+0x8f/0x270
> __sk_destruct+0x64/0x3b0
> sk_destruct+0xa8/0xd0
> __sk_free+0x2e8/0x3d0
> sk_free+0x51/0x90
> netlink_sock_destruct_work+0x1c/0x20
> process_one_work+0x411/0x710
> worker_thread+0x6fd/0xa80
>
> Link: https://syzkaller.appspot.com/bug?id=fc0fa5a53db9edd261d56e74325419faf18bd0df
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: netdev@vger.kernel.org
> Cc: stable@vger.kernel.org
> Reported-by: syzbot+f9f76f4a0766420b4a02@syzkaller.appspotmail.com
> Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org>
> ---
> net/nfc/netlink.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
Cc: <stable@vger.kernel.org>
Fixes: 4d12b8b129f1 ("NFC: add nfc generic netlink interface")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
I will fix other similar cases.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-12-09 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 18:27 [PATCH] nfc: fix segfault in nfc_genl_dump_devices_done Tadeusz Struk
2021-12-09 8:12 ` Krzysztof Kozlowski [this message]
2021-12-09 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20dcbf40-0ca0-690d-182a-e21ee6af1db4@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+f9f76f4a0766420b4a02@syzkaller.appspotmail.com \
--cc=tadeusz.struk@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.