From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82E98C19F2B for ; Fri, 29 Jul 2022 10:29:19 +0000 (UTC) Received: from localhost ([::1]:58770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHNF8-0001ca-7u for qemu-devel@archiver.kernel.org; Fri, 29 Jul 2022 06:29:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHN5X-0005E4-Qf for qemu-devel@nongnu.org; Fri, 29 Jul 2022 06:19:29 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:44334) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oHN5V-0004QF-0J for qemu-devel@nongnu.org; Fri, 29 Jul 2022 06:19:22 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3B9F21F9A5; Fri, 29 Jul 2022 10:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1659089959; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=97ZZT9UjjKfIwRIPlhdlhBMgHHrP5VhQF6vYb9drdoo=; b=DBFOL7+763NlkTxM5N/KW93fW+7mN61FmV/G6SlpSE17DKa4/Z4CFJT4haCNOla5U8CNv4 26t8frFHxFqiUHidmNdX7wD+WaufGR8QcAK9uM27w2tR3cf3Y1d7cc6w3MhCc5UDqqQFby uiyg859qbB0ocrIq37Y9e2wwmut/R/k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1659089959; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=97ZZT9UjjKfIwRIPlhdlhBMgHHrP5VhQF6vYb9drdoo=; b=tujgVwcuB0ECbvg855acHvZ4ZsUahZ478wa9NVD87AtONeBCCcB+zkGw2Q9Qjl168k/uld BUAptVZbpZS3hHCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0D75713A8E; Fri, 29 Jul 2022 10:19:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Fy64ASe042LzeQAAMHmgww (envelope-from ); Fri, 29 Jul 2022 10:19:19 +0000 Message-ID: <20edd357-716f-c84c-9714-607f7f64db5c@suse.de> Date: Fri, 29 Jul 2022 12:19:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: virtio: why no full reset on virtio_set_status 0 ? Content-Language: en-US To: "Michael S. Tsirkin" Cc: Jason Wang , qemu-devel , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Marcel Apfelbaum References: <8350fff5-f8d7-11a4-9f3a-aac8b7f5a964@suse.de> <20220727112737-mutt-send-email-mst@kernel.org> <8a8475c7-c720-1aef-02bb-ca4cb3c1ff68@suse.de> <20220728093501-mutt-send-email-mst@kernel.org> <20220729061221-mutt-send-email-mst@kernel.org> From: Claudio Fontana In-Reply-To: <20220729061221-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.29; envelope-from=cfontana@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/29/22 12:13, Michael S. Tsirkin wrote: > On Fri, Jul 29, 2022 at 11:46:05AM +0200, Claudio Fontana wrote: >>>> @@ -2025,7 +2031,6 @@ void virtio_reset(void *opaque) >>>> VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(vdev); >>>> int i; >>>> >>>> - virtio_set_status(vdev, 0); >>>> if (current_cpu) { >>>> /* Guest initiated reset */ >>>> vdev->device_endian = virtio_current_cpu_endian(); >>>> -- >>>> 2.26.2 >>> >>> As you say this is incomplete ... bout could you share a bit more >>> of what issue does this address? >>> >> >> Hi, the problem I am trying to address is a segfault in OVS/dpdk that looks like this: > > Sorry I was not clear. What I mean is, you don't yet know why does removing > virtio_set_status call here prevent the crash in ovs, do you? > I have no idea. Trying to collect logs to figure things out, but as mentioned the logs easily hide the issue. Likely there is just more to study here.