From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751743AbdCANqI (ORCPT ); Wed, 1 Mar 2017 08:46:08 -0500 Received: from cn.fujitsu.com ([59.151.112.132]:65354 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751365AbdCANqG (ORCPT ); Wed, 1 Mar 2017 08:46:06 -0500 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="16095658" Subject: Re: [PATCH] x86/apic: Remove the extra judgement of skipped IO APIC setup To: Ingo Molnar References: <1487841401-1543-1-git-send-email-douly.fnst@cn.fujitsu.com> <20170301090455.GA23669@gmail.com> CC: , , , , , , From: Dou Liyang Message-ID: <20f40557-b9ca-7442-a9af-3beccb0093d9@cn.fujitsu.com> Date: Wed, 1 Mar 2017 17:31:55 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170301090455.GA23669@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.106] X-yoursite-MailScanner-ID: C371847D8B60.AAA41 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Ingo, At 03/01/2017 05:04 PM, Ingo Molnar wrote: [...] >> + pr_info("Not init interrupt remapping due to skipped IO-APIC setup\n"); > > So you replaced a perfectly readable kernel message: > > - pr_info("Not enabling interrupt remapping due to skipped IO-APIC setup\n"); > > ... with an unreadable one: > > + pr_info("Not init interrupt remapping due to skipped IO-APIC setup\n"); > > Why? I am very sorry. Because of my weak English skills :) . I am trying to improve my English ability. > > Also, the changelog is pretty much unreadable as well: > >> As the commit 2e63ad4bd5dd ("x86/apic: Do not init irq remapping >> if ioapic is disabled") added the judgement of skipped IO APIC >> setup at the beginning of enable_IR_x2apic(). It may be redundant >> that we check it again when we try to enable the interrupt mapping. >> >> So, remove the one in try_to_enable_IR() and refine them for >> better readability. > > I edited it to: Thanks very much ! it became very clear. > > The following commit: > > 2e63ad4bd5dd ("x86/apic: Do not init irq remapping if ioapic is disabled") > > ... added a check for skipped IO-APIC setup to enable_IR_x2apic(), but this Could you tell me what is the meaning of "..." . How to use it? > check is also duplicated in try_to_enable_IR() - and it will never succeed in > calling irq_remapping_enable(). > > Remove the whole irq_remapping_enable() complication: if the IO-APIC is > disabled we cannot enable IRQ remapping. > > And I restored the original pr_info() message as well. Yes. Thanks! Sincerely, Liyang > > Thanks, > > Ingo > > >