From: Laurent Vivier <laurent@vivier.eu>
To: Taylor Simpson <tsimpson@quicinc.com>,
riku.voipio@iki.fi, qemu-devel@nongnu.org
Subject: Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project and therefore do not conform to qemu coding standards
Date: Tue, 19 Nov 2019 09:39:19 +0100 [thread overview]
Message-ID: <20ff3dba-2ee8-8ef2-aa50-ecbd52092c4d@vivier.eu> (raw)
In-Reply-To: <1574121497-2433-1-git-send-email-tsimpson@quicinc.com>
Hi,
thank you for your contribution.
I think we need some little changes:
- fix the errors reported by patchew (you can check your patch with
scripts/checkpatch.pl)
- split the patch in two parts: one to add the target, one to add the
linux-user part,
- add the license header in files where it is missing.
(you can use the SPDX tag)
- I think you can remove the "DEBUG_HEX" in cpu_loop() as most of the
information can be displayed by QEMU_STRACE env variable. The one in
hexagon_tr_translate_packet() can be done using QEMU_SINGLESTEP (if I
understand the purpose),
- The "[__SIGRTMAX - 1] = __SIGRTMIN + 1" part must be in a separate
patch. As I said at KVM Forum, I agree with this change if it doesn't
break anything else but it can be controversial.
Thanks,
Laurent
Le 19/11/2019 à 00:58, Taylor Simpson a écrit :
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> configure | 9 +
> default-configs/hexagon-linux-user.mak | 1 +
> include/elf.h | 2 +
> linux-user/elfload.c | 16 ++
> linux-user/hexagon/cpu_loop.c | 103 +++++++++
> linux-user/hexagon/signal.c | 276 +++++++++++++++++++++++
> linux-user/hexagon/sockbits.h | 3 +
> linux-user/hexagon/syscall_nr.h | 331 ++++++++++++++++++++++++++++
> linux-user/hexagon/target_cpu.h | 35 +++
> linux-user/hexagon/target_elf.h | 24 ++
> linux-user/hexagon/target_fcntl.h | 3 +
> linux-user/hexagon/target_signal.h | 19 ++
> linux-user/hexagon/target_structs.h | 31 +++
> linux-user/hexagon/target_syscall.h | 17 ++
> linux-user/hexagon/termbits.h | 231 +++++++++++++++++++
> linux-user/signal.c | 8 +
> linux-user/syscall.c | 2 +
> linux-user/syscall_defs.h | 33 +++
> target/hexagon/Makefile.objs | 6 +
> target/hexagon/cpu-param.h | 11 +
> target/hexagon/cpu.c | 283 ++++++++++++++++++++++++
> target/hexagon/cpu.h | 146 ++++++++++++
> target/hexagon/cpu_bits.h | 15 ++
> target/hexagon/helper.h | 3 +
> target/hexagon/imported/global_types.h | 25 +++
> target/hexagon/imported/iss_ver_registers.h | 183 +++++++++++++++
> target/hexagon/imported/max.h | 78 +++++++
> target/hexagon/imported/regs.h | 19 ++
> target/hexagon/op_helper.c | 29 +++
> target/hexagon/translate.c | 220 ++++++++++++++++++
> target/hexagon/translate.h | 22 ++
> 31 files changed, 2184 insertions(+)
> create mode 100644 default-configs/hexagon-linux-user.mak
> create mode 100644 linux-user/hexagon/cpu_loop.c
> create mode 100644 linux-user/hexagon/signal.c
> create mode 100644 linux-user/hexagon/sockbits.h
> create mode 100644 linux-user/hexagon/syscall_nr.h
> create mode 100644 linux-user/hexagon/target_cpu.h
> create mode 100644 linux-user/hexagon/target_elf.h
> create mode 100644 linux-user/hexagon/target_fcntl.h
> create mode 100644 linux-user/hexagon/target_signal.h
> create mode 100644 linux-user/hexagon/target_structs.h
> create mode 100644 linux-user/hexagon/target_syscall.h
> create mode 100644 linux-user/hexagon/termbits.h
> create mode 100644 target/hexagon/Makefile.objs
> create mode 100644 target/hexagon/cpu-param.h
> create mode 100644 target/hexagon/cpu.c
> create mode 100644 target/hexagon/cpu.h
> create mode 100644 target/hexagon/cpu_bits.h
> create mode 100644 target/hexagon/helper.h
> create mode 100644 target/hexagon/imported/global_types.h
> create mode 100644 target/hexagon/imported/iss_ver_registers.h
> create mode 100644 target/hexagon/imported/max.h
> create mode 100644 target/hexagon/imported/regs.h
> create mode 100644 target/hexagon/op_helper.c
> create mode 100644 target/hexagon/translate.c
> create mode 100644 target/hexagon/translate.h
>
next prev parent reply other threads:[~2019-11-19 8:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 23:58 [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project and therefore do not conform to qemu coding standards Taylor Simpson
2019-11-19 1:31 ` no-reply
2019-11-19 8:51 ` Exclude paths from checkpatch (was: Re: [PATCH] Add minimal Hexagon target) Philippe Mathieu-Daudé
2019-11-19 13:33 ` Richard Henderson
2019-11-19 15:37 ` Paolo Bonzini
2019-11-19 16:14 ` Stefan Hajnoczi
2019-11-19 8:39 ` Laurent Vivier [this message]
2019-11-19 9:03 ` [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project and therefore do not conform to qemu coding standards Laurent Vivier
2019-11-19 14:14 ` Eric Blake
2019-11-19 15:11 ` Philippe Mathieu-Daudé
2019-11-19 15:19 ` Philippe Mathieu-Daudé
2019-11-19 17:22 ` Taylor Simpson
2019-11-19 17:32 ` Peter Maydell
2019-11-19 18:13 ` Laurent Vivier
2019-11-20 4:48 ` Taylor Simpson
2019-11-20 8:33 ` Laurent Vivier
2019-11-20 9:02 ` Richard Henderson
2019-11-20 12:58 ` Taylor Simpson
2019-11-20 14:14 ` Laurent Vivier
2019-11-20 15:19 ` Taylor Simpson
2019-11-20 16:40 ` Alex Bennée
2019-11-20 17:09 ` Philippe Mathieu-Daudé
2019-11-19 19:36 ` Richard Henderson
2019-11-20 2:26 ` Aleksandar Markovic
2019-11-20 7:49 ` Richard Henderson
2019-11-21 6:01 ` Aleksandar Markovic
2019-11-21 8:55 ` Richard Henderson
2019-11-20 8:41 ` Laurent Vivier
2019-11-20 17:34 ` Alex Bennée
2019-11-19 19:33 ` Richard Henderson
2019-11-20 5:15 ` Taylor Simpson
2019-11-20 8:06 ` Richard Henderson
2019-11-20 12:51 ` Taylor Simpson
2019-11-20 14:43 ` Richard Henderson
2019-11-20 15:17 ` Taylor Simpson
2019-11-21 9:00 ` Richard Henderson
2019-11-21 19:20 ` Aleksandar Markovic
2019-11-21 19:52 ` Taylor Simpson
2019-11-21 20:44 ` Aleksandar Markovic
2019-11-21 23:51 ` Taylor Simpson
2019-11-22 9:33 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20ff3dba-2ee8-8ef2-aa50-ecbd52092c4d@vivier.eu \
--to=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.