From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH] libvhd: use UTC for VHD timestamp
Date: Fri, 30 Aug 2013 16:52:24 +0100
Message-ID: <21024.49080.965845.357206@mariner.uk.xensource.com>
References: <1377868040-13668-1-git-send-email-wei.liu2@citrix.com>
	<20130830155013.GY15729@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130830155013.GY15729@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrei Lifchits <andrei.lifchits@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Wei Liu writes ("Re: [PATCH] libvhd: use UTC for VHD timestamp"):
> Update commit message.

Thanks.

> From: Wei Liu <wei.liu2@citrix.com>
> Date: Fri, 30 Aug 2013 12:33:33 +0100
> Subject: [PATCH] libvhd: use UTC for VHD timestamp
> 
> [ported from xapi-project/blktap a79ac2c05f9 ("XOP-289: use UTC for VHD
> timestamps")]
> 
> Currently, the local timezone is factored into VHD timestamps due to the
> use of mktime(). This breaks "vhd-util check" for VHDs created in one
> timezone and then moved westward, which results in "primary footer
> invalid: creation time in future" errors.

The existing code here is, erm, "surprising".  Thanks for your
attention to it!

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Ian.