From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 704F0C433F5 for ; Wed, 15 Sep 2021 07:22:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C8D161164 for ; Wed, 15 Sep 2021 07:22:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3C8D161164 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQPFE-0008Gd-CO for qemu-devel@archiver.kernel.org; Wed, 15 Sep 2021 03:22:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQPC8-0004xJ-EF; Wed, 15 Sep 2021 03:19:00 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:40838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQPC3-0007ad-0M; Wed, 15 Sep 2021 03:19:00 -0400 Received: by mail-wr1-x429.google.com with SMTP id q26so2197226wrc.7; Wed, 15 Sep 2021 00:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lxqks9hN8p6vJMT6A0n9FtHBxpUq7EEMYkl2tekM3o0=; b=jvxWtztziTkC06llosazUdDK85mqxv70EuwXcZdlnUuP+hXKa0/JFnc80BK5Y+elgy 9y3qSTQN21SHdZvXbhSurNw8a6Z1sXop8GogJ3pFO4INVouCiiCVrquFRUbWXodsFiAc 2Z8r4DgthNHgvgAaDu6y3CBwgKZFnj0rWUfDLaKP4y8s/gbkUkX7/yoxg0Q6ODLiFKjG D03gB+l0PcpNiaWQ8Kgan4yyDfgAvSf6tiYoUGw22TxY9EUym1IXuaaT0cexJFXWntN1 sB5urYa4O6Y2BAR2ujJZu268E9popFxeBN7LuHG56GqCMPc8RFQSr9Joc9Xe4gyCr6hx VuCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lxqks9hN8p6vJMT6A0n9FtHBxpUq7EEMYkl2tekM3o0=; b=TFeu/+xLhDQwQ99TDBd+AXILyHYlZ2PtIBN3nglVxWdfEVuSKi1QO+73j4je2Afv9T 1QOOkehKCb2KCBcMWYppKfRP6QHqGcFQAqypbalUfUM2qV4+CY7GUWNqbavZckyoNluL xSladH5rlW+gGM0ksaCwmA/mnMeBmwEMjgk4ZCZvsbWXe4JfR5L7jbE38oP33WZEo7wh wPOBvdqbxIi+wJdpJZNRGdNlyzpBTRYJdaSBebIxajd09L2DUaP09Xx///t8YuhVI+TD KXtgHsRZP5m9Q2VUwo6+fxu2plOHLKuZz9lkmCadGvFJLIioC6FtQcFb3GoQASHnXy3c Px0Q== X-Gm-Message-State: AOAM530/bPtkB66UqTqni9fGebU3L0vNb4wFjjYj4EciIfmTGMc5BJik gRe5w0sy0fKEU8K9OUSgh6I= X-Google-Smtp-Source: ABdhPJwCEX0rAOnC5GYV7iTT0QWnvgSmZuKzrKTCCn7PKz0bMFQnVLKY76U0VTdhxYK65LEyYtuMew== X-Received: by 2002:a5d:58c9:: with SMTP id o9mr3323687wrf.279.1631690332130; Wed, 15 Sep 2021 00:18:52 -0700 (PDT) Received: from [192.168.1.36] (14.red-83-35-25.dynamicip.rima-tde.net. [83.35.25.14]) by smtp.gmail.com with ESMTPSA id z6sm3434468wmp.1.2021.09.15.00.18.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 00:18:51 -0700 (PDT) Subject: Re: [PATCH v2 16/53] target/microblaze: convert to use format_state instead of dump_state To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-17-berrange@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <21032bce-bdbb-1a0f-f5a5-71350ad79c85@amsat.org> Date: Wed, 15 Sep 2021 09:18:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210914142042.1655100-17-berrange@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-1.969, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cornelia Huck , David Hildenbrand , Bin Meng , Mark Cave-Ayland , Yuval Shaia , Peter Xu , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , qemu-ppc@nongnu.org, Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Laurent Vivier , Palmer Dabbelt , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/microblaze/cpu.c | 2 +- > target/microblaze/cpu.h | 2 +- > target/microblaze/translate.c | 45 ++++++++++++++++++----------------- > 3 files changed, 25 insertions(+), 24 deletions(-) > for (i = 0; i < 32; i++) { > - qemu_fprintf(f, "r%2.2d=%08x%c", > - i, env->regs[i], i % 4 == 3 ? '\n' : ' '); > + g_string_append_printf(buf, "r%2.2d=%08x%c", > + i, env->regs[i], i % 4 == 3 ? '\n' : ' '); > } > - qemu_fprintf(f, "\n"); > + g_string_append_printf(buf, "\n"); g_string_append_c(), otherwise: Reviewed-by: Philippe Mathieu-Daudé > } > > void mb_tcg_init(void) > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mQPCA-00050W-Ap for mharc-qemu-riscv@gnu.org; Wed, 15 Sep 2021 03:19:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQPC8-0004xJ-EF; Wed, 15 Sep 2021 03:19:00 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:40838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQPC3-0007ad-0M; Wed, 15 Sep 2021 03:19:00 -0400 Received: by mail-wr1-x429.google.com with SMTP id q26so2197226wrc.7; Wed, 15 Sep 2021 00:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lxqks9hN8p6vJMT6A0n9FtHBxpUq7EEMYkl2tekM3o0=; b=jvxWtztziTkC06llosazUdDK85mqxv70EuwXcZdlnUuP+hXKa0/JFnc80BK5Y+elgy 9y3qSTQN21SHdZvXbhSurNw8a6Z1sXop8GogJ3pFO4INVouCiiCVrquFRUbWXodsFiAc 2Z8r4DgthNHgvgAaDu6y3CBwgKZFnj0rWUfDLaKP4y8s/gbkUkX7/yoxg0Q6ODLiFKjG D03gB+l0PcpNiaWQ8Kgan4yyDfgAvSf6tiYoUGw22TxY9EUym1IXuaaT0cexJFXWntN1 sB5urYa4O6Y2BAR2ujJZu268E9popFxeBN7LuHG56GqCMPc8RFQSr9Joc9Xe4gyCr6hx VuCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lxqks9hN8p6vJMT6A0n9FtHBxpUq7EEMYkl2tekM3o0=; b=TFeu/+xLhDQwQ99TDBd+AXILyHYlZ2PtIBN3nglVxWdfEVuSKi1QO+73j4je2Afv9T 1QOOkehKCb2KCBcMWYppKfRP6QHqGcFQAqypbalUfUM2qV4+CY7GUWNqbavZckyoNluL xSladH5rlW+gGM0ksaCwmA/mnMeBmwEMjgk4ZCZvsbWXe4JfR5L7jbE38oP33WZEo7wh wPOBvdqbxIi+wJdpJZNRGdNlyzpBTRYJdaSBebIxajd09L2DUaP09Xx///t8YuhVI+TD KXtgHsRZP5m9Q2VUwo6+fxu2plOHLKuZz9lkmCadGvFJLIioC6FtQcFb3GoQASHnXy3c Px0Q== X-Gm-Message-State: AOAM530/bPtkB66UqTqni9fGebU3L0vNb4wFjjYj4EciIfmTGMc5BJik gRe5w0sy0fKEU8K9OUSgh6I= X-Google-Smtp-Source: ABdhPJwCEX0rAOnC5GYV7iTT0QWnvgSmZuKzrKTCCn7PKz0bMFQnVLKY76U0VTdhxYK65LEyYtuMew== X-Received: by 2002:a5d:58c9:: with SMTP id o9mr3323687wrf.279.1631690332130; Wed, 15 Sep 2021 00:18:52 -0700 (PDT) Received: from [192.168.1.36] (14.red-83-35-25.dynamicip.rima-tde.net. [83.35.25.14]) by smtp.gmail.com with ESMTPSA id z6sm3434468wmp.1.2021.09.15.00.18.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 00:18:51 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH v2 16/53] target/microblaze: convert to use format_state instead of dump_state To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org Cc: Peter Maydell , Chris Wulff , David Hildenbrand , Bin Meng , Mark Cave-Ayland , Yuval Shaia , Laurent Vivier , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , Palmer Dabbelt , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Peter Xu , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-17-berrange@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <21032bce-bdbb-1a0f-f5a5-71350ad79c85@amsat.org> Date: Wed, 15 Sep 2021 09:18:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210914142042.1655100-17-berrange@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-1.969, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2021 07:19:00 -0000 On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/microblaze/cpu.c | 2 +- > target/microblaze/cpu.h | 2 +- > target/microblaze/translate.c | 45 ++++++++++++++++++----------------- > 3 files changed, 25 insertions(+), 24 deletions(-) > for (i = 0; i < 32; i++) { > - qemu_fprintf(f, "r%2.2d=%08x%c", > - i, env->regs[i], i % 4 == 3 ? '\n' : ' '); > + g_string_append_printf(buf, "r%2.2d=%08x%c", > + i, env->regs[i], i % 4 == 3 ? '\n' : ' '); > } > - qemu_fprintf(f, "\n"); > + g_string_append_printf(buf, "\n"); g_string_append_c(), otherwise: Reviewed-by: Philippe Mathieu-Daudé > } > > void mb_tcg_init(void) >