From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH] libxl: make libxl__poller_put tolerate p==NULL libxl_event_wait Date: Fri, 11 Oct 2013 15:51:30 +0100 Message-ID: <21080.4210.5776.457582@mariner.uk.xensource.com> References: <52399CA2.8080504@citrix.com> <1380432276-16016-1-git-send-email-mattjd@gmail.com> <1380807569.25618.0.camel@kazak.uk.xensource.com> <21079.56627.513787.948179@mariner.uk.xensource.com> <1381492052.24708.12.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1381492052.24708.12.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Andrew Cooper , Matthew Daley , Stefano Stabellini , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("Re: [PATCH] libxl: make libxl__poller_put tolerate p==NULL libxl_event_wait"): > On Fri, 2013-10-11 at 12:12 +0100, Ian Jackson wrote: > > commit 9134bb273db4d55bec247d751b1de6e7876a7fe7 > > Author: Ian Jackson > > Date: Fri Oct 11 12:10:45 2013 +0100 > > > > libxl: make libxl__poller_put tolerate p==NULL > > > > This is less fragile, and more in keeping with the usual style of > > initialising everything to 0 and freeing things unconditionally. > > > > Correspondingly, remove the tests at the call sites. > > > > Apropos of c1f3f174. No overall functional change. > > > > Signed-off-by: Ian Jackson > > Yes, good idea. > > Acked-by: Ian Campbell Pushed, thanks. Ian.