From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] include/lapi: add sctp.h
Date: Wed, 28 Mar 2018 17:35:57 +0300 [thread overview]
Message-ID: <210efb77-c661-5fdd-abd3-16e419103461@oracle.com> (raw)
In-Reply-To: <20180326105555.GA7242@x230>
On 26.03.2018 13:55, Petr Vorel wrote:
>> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
>> ---
>> v2: include linux/sctp.h header and check it in the configure
Applied the patch-set.
> BTW SCTP_SOCKOPT_BINDX_ADD is defined in both <linux/sctp.h> and <netinet/sctp.h>, so if we
> ever in future want to have some definitions from netinet/sctp.h, I'd be to create special
> file include/lapi/netinet_sctp.h (the same like include/lapi/netinet_in.h - taking that
> default is for "kernel/").
>
I think if we have netinet/sctp.h it should take precedences
over linux/sctp.h. In OL7 it is provided by optional
lksctp-tools-devel package.
Thanks,
Alexey
> And we have included netinet/sctp.h in sources (utils/sctp/include/netinet/sctp.h), IMHO
> not good idea to have common headers in our sources.
>
>
> Kind regards,
> Petr
>
next prev parent reply other threads:[~2018-03-28 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 15:37 [LTP] [PATCH v2 0/2] sctp: add new regression test for CVE-2018-5803 Alexey Kodanev
2018-03-23 15:37 ` [LTP] [PATCH v2 1/2] include/lapi: add sctp.h Alexey Kodanev
2018-03-26 10:55 ` Petr Vorel
2018-03-28 14:35 ` Alexey Kodanev [this message]
2018-03-29 6:12 ` Petr Vorel
2018-03-23 15:37 ` [LTP] [PATCH v2 2/2] sctp: new regression test sctp_big_chunk for CVE-2018-5803 Alexey Kodanev
2018-03-26 11:05 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=210efb77-c661-5fdd-abd3-16e419103461@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.