From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 1/8] doc: add doc to explain compiling and
	testing of PMD
Date: Fri, 07 Apr 2017 11:34:09 +0200
Message-ID: <2110765.8k0m84YbOW@xps13>
References: <1491059040-20647-1-git-send-email-shijith.thotton@caviumnetworks.com>
 <20170407070724.GA5581@localhost.localdomain>
 <B27915DBBA3421428155699D51E4CFE2332B3003@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Shijith Thotton <shijith.thotton@caviumnetworks.com>, dev@dpdk.org, "Yigit,
 Ferruh" <ferruh.yigit@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com
 [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 6A5B6326C
 for <dev@dpdk.org>; Fri,  7 Apr 2017 11:34:11 +0200 (CEST)
Received: by mail-wr0-f179.google.com with SMTP id g19so55082575wrb.0
 for <dev@dpdk.org>; Fri, 07 Apr 2017 02:34:11 -0700 (PDT)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2332B3003@IRSMSX103.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-04-07 09:23, Mcnamara, John:
> 
> > -----Original Message-----
> > From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com]
> > Sent: Friday, April 7, 2017 8:07 AM
> > To: Thomas Monjalon <thomas.monjalon@6wind.com>
> > Cc: Mcnamara, John <john.mcnamara@intel.com>; dev@dpdk.org; Yigit, Ferruh
> > <ferruh.yigit@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and
> > testing of PMD
> > 
> > On Thu, Apr 06, 2017 at 08:30:21PM +0200, Thomas Monjalon wrote:
> > > 2017-04-06 13:21, Shijith Thotton:
> > > > Add a section in NIC drivers documentation to explain compiling and
> > > > testing of a PMD. It also mentions about host setup, which is
> > > > required before running testpmd.
> > > >
> > > > Add label "testpmd_ug" to refer user guide.
> > > >
> > > > Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
> > >
> > > It is really good to factorize documentation.
> > >
> > > This doc is about testpmd in Linux
> > > and does not refer to FreeBSD.
> > > Do we assume to take Linux as the reference?
> > 
> > I can submit v2 with a subsection for running testpmd in FreeBSD.
> 
> Hi,
> 
> > I can submit v2 with a subsection for running testpmd in FreeBSD.
> 
> I don't think that is necessary. You patch already calls out the
> Linux and FreeBSD Getting Started Guides. I think that is enough.
> 
> 
> @tmonjalo
> For me this new "Compiling and testing a PMD for a NIC" section
> is a way of avoiding duplicate sections in the NIC guides. I don't
> think it has to be a definitive guide to TestPMD.
> 
> As and aside, I would like to do something similar with the sample
> app guides, i.e., have one section on compilation that the other
> app guides can refer to. I'll try to add that in the next release.
> 
> So for me this patchset is okay as it is.

OK
I just wanted to start discussing about more factorization.
Thanks for leading this work, John.