All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Maksym Sobolyev <sobomax@sippysoft.com>
Subject: ms/customizable-ident-expansion (was: What's cooking in git.git (Oct 2021, #07; Fri, 29))
Date: Mon, 01 Nov 2021 20:39:51 +0100	[thread overview]
Message-ID: <211101.86fssf3bn3.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqr1c3e57a.fsf@gitster.g>


On Fri, Oct 29 2021, Junio C Hamano wrote:

> * ms/customizable-ident-expansion (2021-09-01) 1 commit
>  - keyword expansion: make "$Id$" string configurable
>
>  Instead of "$Id$", user-specified string (like $FreeBSD$) can be
>  used as an in-blob placeholder for keyword expansion.
>
>  What's the status of this one?  Meh?

I reviewed this the other day, but that review didn't yield a mailing
list message.

I think some of the seeming re-invention of "struct strbuf" is a bit
nasty, but in trying to see if I could replace it I came to head with
existing code that this was extending, so it's nothing new.

But as for the feature it's clearly useful to some, and helps SCM
inter-op, so even if I'm also rather "meh" on it I think it would be
good to merge it down, it's clearly very useful to its (small) target
audience, and doesn't seem to be harming anything else.

  parent reply	other threads:[~2021-11-01 19:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30  0:17 What's cooking in git.git (Oct 2021, #07; Fri, 29) Junio C Hamano
2021-11-01 19:26 ` ab/config-based-hooks-2 (was: What's cooking in git.git (Oct 2021, #07; Fri, 29)) Ævar Arnfjörð Bjarmason
2021-11-01 20:17   ` ab/config-based-hooks-2 Junio C Hamano
2021-11-01 19:27 ` ab/only-single-progress-at-once (was: What's cooking in git.git (Oct 2021, #07; Fri, 29)) Ævar Arnfjörð Bjarmason
2021-11-01 19:30 ` tb/plug-pack-bitmap-leaks " Ævar Arnfjörð Bjarmason
2021-11-01 19:32 ` tp/send-email-completion " Ævar Arnfjörð Bjarmason
2021-11-01 19:34 ` js/scalar " Ævar Arnfjörð Bjarmason
2021-11-01 19:39 ` Ævar Arnfjörð Bjarmason [this message]
2021-11-01 20:23   ` ms/customizable-ident-expansion Junio C Hamano
     [not found]     ` <CABFYoQA82u8Um6L439_bU4a+WpkdXOcbU8foPjqnVw+4MnNU0A@mail.gmail.com>
2021-11-08 19:14       ` ms/customizable-ident-expansion Ævar Arnfjörð Bjarmason
2021-11-08 20:01         ` ms/customizable-ident-expansion Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=211101.86fssf3bn3.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sobomax@sippysoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.