From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: rshriram@cs.ubc.ca, Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] libxl: Deprecate synchronous waiting for the device model
Date: Mon, 4 Nov 2013 17:03:22 +0000 [thread overview]
Message-ID: <21111.54106.993485.772732@mariner.uk.xensource.com> (raw)
In-Reply-To: <1383583857.8826.122.camel@kazak.uk.xensource.com>
Ian Campbell writes ("Re: [PATCH] libxl: Deprecate synchronous waiting for the device model"):
> On Mon, 2013-10-14 at 17:30 +0100, Ian Jackson wrote:
> > /*
> > - * libxl__wait_for_offspring - Wait for child state
> > + * libxl__xenstore_child_wait_deprecated - Wait for daemonic child IPC
> > [...]
> > This function is currently used only by
> > + * libxl__wait_for_device_model_deprecated.
>
> Could it become a static helper in tools/libxl/libxl_device.c (which is
> where libxl__wait_for_device_model_deprecated seems to live) then? Tat
> would get it out of the internal API immediately...
At the moment its called in libxl_device.c but defined in
libxl_exec.c. I'm not too keen on moving about something which we
intend to get rid of.
Ian.
next prev parent reply other threads:[~2013-11-04 17:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 22:16 [PATCH 0 of 5 V2] Remus/Libxl: Network buffering support Shriram Rajagopalan
2013-08-29 22:16 ` [PATCH 1 of 5 V2] remus: add libnl3 dependency to autoconf scripts Shriram Rajagopalan
2013-09-04 13:40 ` Ian Campbell
2013-10-09 2:14 ` Shriram Rajagopalan
2013-10-09 8:06 ` Ian Campbell
2013-10-09 16:27 ` Shriram Rajagopalan
2013-10-09 16:36 ` Ian Campbell
2013-08-29 22:16 ` [PATCH 2 of 5 V2] tools/hotplug: Remus network buffering setup scripts Shriram Rajagopalan
2013-09-04 13:50 ` Ian Campbell
2013-08-29 22:16 ` [PATCH 3 of 5 V2] tools/libxl: setup/teardown Remus network buffering Shriram Rajagopalan
2013-09-04 15:17 ` Ian Campbell
2013-10-14 14:23 ` Shriram Rajagopalan
2013-10-15 10:34 ` Ian Campbell
2013-09-04 16:16 ` Ian Jackson
2013-09-04 17:22 ` Shriram Rajagopalan
2013-10-09 16:32 ` Shriram Rajagopalan
2013-10-14 16:30 ` [PATCH] libxl: Deprecate synchronous waiting for the device model Ian Jackson
2013-11-04 16:50 ` Ian Campbell
2013-11-04 17:03 ` Ian Jackson [this message]
2013-11-12 16:58 ` [PATCH RESEND] " Ian Jackson
2013-11-12 17:25 ` Ian Campbell
2013-11-12 17:27 ` Ian Jackson
2013-10-14 16:34 ` [PATCH 3 of 5 V2] tools/libxl: setup/teardown Remus network buffering [and 1 more messages] Ian Jackson
2013-08-29 22:16 ` [PATCH 4 of 5 V2] tools/libxl: Control network buffering in remus callbacks Shriram Rajagopalan
2013-09-04 15:19 ` Ian Campbell
2013-09-05 11:25 ` Ian Jackson
2013-08-29 22:16 ` [PATCH 5 of 5 V2] tools/xl: Remus - Network buffering cmdline switch Shriram Rajagopalan
2013-09-04 15:24 ` Ian Campbell
2013-09-04 13:21 ` [PATCH 0 of 5 V2] Remus/Libxl: Network buffering support Shriram Rajagopalan
2013-09-04 13:27 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21111.54106.993485.772732@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.