From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] librte_pmd_e1000: power down the serdes link Date: Mon, 23 Mar 2015 12:40:11 +0100 Message-ID: <2111723.CRdqpS7LaL@xps13> References: <1425700658-12077-1-git-send-email-jiaxt@sinogrid.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1425700658-12077-1-git-send-email-jiaxt-ZrUwlr9QczFWk0Htik3J/w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" There is no maintainer declared for e1000. Maybe that an Intel expert could check this patch, please? 2015-03-07 11:57, Shelton Chia: > Signed-off-by: Shelton Chia > --- > lib/librte_pmd_e1000/igb_ethdev.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_pmd_e1000/igb_ethdev.c b/lib/librte_pmd_e1000/igb_ethdev.c > index 504ae74..314ef2a 100644 > --- a/lib/librte_pmd_e1000/igb_ethdev.c > +++ b/lib/librte_pmd_e1000/igb_ethdev.c > @@ -948,7 +948,10 @@ eth_igb_stop(struct rte_eth_dev *dev) > } > > /* Power down the phy. Needed to make the link go Down */ > - e1000_power_down_phy(hw); > + if (hw->phy.media_type == e1000_media_type_copper) > + e1000_power_down_phy(hw); > + else > + e1000_shutdown_fiber_serdes_link(hw); > > igb_dev_clear_queues(dev); > >