All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Maksym Sobolyev <sobomax@sippysoft.com>
Subject: ms/customizable-ident-expansion (was: What's cooking in git.git (Dec 2021, #03; Fri, 10))
Date: Sun, 12 Dec 2021 23:42:00 +0100	[thread overview]
Message-ID: <211212.86fsqxa19o.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqilvvluoa.fsf@gitster.g>


On Fri, Dec 10 2021, Junio C Hamano wrote:

[CC-ing Maksym, the topic author]

> * ms/customizable-ident-expansion (2021-09-01) 1 commit
>  - keyword expansion: make "$Id$" string configurable
>
>  Instead of "$Id$", user-specified string (like $FreeBSD$) can be
>  used as an in-blob placeholder for keyword expansion.
>
>  Will discard.
>  Stalled for too long.
>  cf. <xmqqfsuosvrh.fsf@gitster.g>
>  cf. <211101.86fssf3bn3.gmgdl@evledraar.gmail.com>
>  source: <pull.1074.v3.git.git.1630462385587.gitgitgadget@gmail.com>

I'd like to see this go in, not because I'd personally find it useful,
but mainly because I didn't find anything wrong with it (per my review
id [1] linked above), and more importantly because the saga ending here
seems rather unfriendly to a first-time contributor.

Wasn't the "stalled for too long" mainly a victim of timing? I.e. that
it happened to be submitted/discussed around the end of the last release
cycle?

Maksym: Are you interested in pursuing this still?

I think per Junio's[2] an updated commit message describing some of the
use-case (and in particular how/why .gitattributes v.s. a git config
setting is needed) might be enough to help move this forward.

1. https://lore.kernel.org/git/211101.86fssf3bn3.gmgdl@evledraar.gmail.com/
2. https://lore.kernel.org/git/xmqqwnlito0b.fsf@gitster.g/

  parent reply	other threads:[~2021-12-12 22:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-11  2:52 What's cooking in git.git (Dec 2021, #03; Fri, 10) Junio C Hamano
2021-12-11  3:44 ` ns/batched-fsync and ns/remerge-diff Neeraj Singh
2021-12-11  6:38   ` Elijah Newren
2021-12-11  8:39 ` What's cooking in git.git (Dec 2021, #03; Fri, 10) Eric Sunshine
2021-12-13 19:08   ` Junio C Hamano
2021-12-11 10:49 ` Elijah Newren
2021-12-13 18:28   ` Junio C Hamano
2021-12-15 18:47   ` Junio C Hamano
2021-12-11 22:09 ` tb/midx-bitmap-corruption-fix Taylor Blau
2021-12-15 18:47   ` tb/midx-bitmap-corruption-fix Junio C Hamano
2021-12-12 18:37 ` ab/common-main-cleanup (was: What's cooking in git.git (Dec 2021, #03; Fri, 10)) Ævar Arnfjörð Bjarmason
2021-12-12 18:41 ` ab/only-single-progress-at-once " Ævar Arnfjörð Bjarmason
2021-12-13  4:44   ` ab/only-single-progress-at-once Junio C Hamano
2021-12-12 22:42 ` Ævar Arnfjörð Bjarmason [this message]
2021-12-13  9:02   ` ms/customizable-ident-expansion Junio C Hamano
2021-12-13 15:32 ` What's cooking in git.git (Dec 2021, #03; Fri, 10) Jeff Hostetler
2021-12-13 15:39 ` Jeff Hostetler
2021-12-14 10:59 ` 'Re: What's cooking in git.git (Dec 2021, #03; Fri, 10)' Teng Long
2021-12-15 18:53   ` Junio C Hamano
2021-12-15 11:10 ` What's cooking in git.git (Dec 2021, #03; Fri, 10) Phillip Wood
2021-12-15 18:54   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=211212.86fsqxa19o.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sobomax@sippysoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.