From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C07BC433F5 for ; Mon, 28 Mar 2022 03:15:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237783AbiC1DRL (ORCPT ); Sun, 27 Mar 2022 23:17:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230495AbiC1DRF (ORCPT ); Sun, 27 Mar 2022 23:17:05 -0400 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB80824588; Sun, 27 Mar 2022 20:15:25 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0V8KfeNU_1648437319; Received: from 30.225.24.93(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0V8KfeNU_1648437319) by smtp.aliyun-inc.com(127.0.0.1); Mon, 28 Mar 2022 11:15:21 +0800 Message-ID: <21126dc4-2b15-bb12-d4d3-b8703be95539@linux.alibaba.com> Date: Mon, 28 Mar 2022 11:15:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v6 15/22] erofs: register cookie context for bootstrap blob Content-Language: en-US To: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com References: <20220325122223.102958-1-jefflexu@linux.alibaba.com> <20220325122223.102958-16-jefflexu@linux.alibaba.com> From: JeffleXu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/28/22 11:04 AM, Gao Xiang wrote: > On Fri, Mar 25, 2022 at 08:22:16PM +0800, Jeffle Xu wrote: >> Registers fscache_cookie for the bootstrap blob file. The bootstrap blob >> file can be specified by a new mount option, which is going to be >> introduced by a following patch. >> >> Something worth mentioning about the cleanup routine. >> >> 1. The init routine is prior to when the root inode gets initialized, >> and thus the corresponding cleanup routine shall be placed inside >> .kill_sb() callback. >> >> 2. The init routine will instantiate anonymous inodes under the >> super_block, and thus .put_super() callback shall also contain the >> cleanup routine. Or we'll get "VFS: Busy inodes after unmount." warning. >> >> Signed-off-by: Jeffle Xu >> --- >> fs/erofs/internal.h | 3 +++ >> fs/erofs/super.c | 17 +++++++++++++++++ >> 2 files changed, 20 insertions(+) >> >> diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h >> index 459f31803c3b..d8c886a7491e 100644 >> --- a/fs/erofs/internal.h >> +++ b/fs/erofs/internal.h >> @@ -73,6 +73,7 @@ struct erofs_mount_opts { >> /* threshold for decompression synchronously */ >> unsigned int max_sync_decompress_pages; >> #endif >> + char *tag; >> unsigned int mount_opt; >> }; >> >> @@ -151,6 +152,8 @@ struct erofs_sb_info { >> /* sysfs support */ >> struct kobject s_kobj; /* /sys/fs/erofs/ */ >> struct completion s_kobj_unregister; >> + >> + struct erofs_fscache *bootstrap; > > the concept of bootstrap is nydus-specific. Actually here we need > a fscache context of the primary device. > > So I prefer struct erofs_fscache *s_fscache; > > Also please help revise the subject and commit message about > bootstrap. > OK, will be done in the next version. -- Thanks, Jeffle