From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets Date: Wed, 30 Mar 2016 12:51:07 +0200 Message-ID: <2113478.WYverkV2By@xps13> References: <1458682638-28378-1-git-send-email-aconole@redhat.com> <6A0DE07E22DDAD4C9103DF62FEBC09090343E973@shsmsx102.ccr.corp.intel.com> <56F38F26.1030707@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Panu Matilainen , "Lu, Wenzhuo" , dev@dpdk.org, "Richardson, Bruce" To: Aaron Conole Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 3EBC92BC9 for ; Wed, 30 Mar 2016 12:53:01 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id 191so84284959wmq.0 for ; Wed, 30 Mar 2016 03:53:01 -0700 (PDT) In-Reply-To: <56F38F26.1030707@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-24 08:54, Panu Matilainen: > --- a/drivers/net/e1000/Makefile > +++ b/drivers/net/e1000/Makefile > @@ -54,6 +54,9 @@ else > # > CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter > CFLAGS_BASE_DRIVER += -Wno-unused-variable > +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1) > +CFLAGS_BASE_DRIVER += -Wno-misleading-indentation > +endif Aaron, have you tested this solution? Are you going to provide a v3?