From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [OSSTest PATCH [RFC] 4/4] make-flight: Fedora guest tests Date: Fri, 13 Dec 2013 18:20:14 +0000 Message-ID: <21163.20446.6681.459416@mariner.uk.xensource.com> References: <20131212221933.11164.46804.stgit@Solace> <20131212225347.11164.65135.stgit@Solace> <21163.14988.173296.666172@mariner.uk.xensource.com> <1386955925.3980.23.camel@Solace> <21163.17718.481738.503478@mariner.uk.xensource.com> <1386957801.3980.34.camel@Solace> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1386957801.3980.34.camel@Solace> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Dario Faggioli writes ("Re: [Xen-devel] [OSSTest PATCH [RFC] 4/4] make-flight: Fedora guest tests"): > On ven, 2013-12-13 at 17:34 +0000, Ian Jackson wrote: > > Perhaps. I'm not sure whether it wants to be a different script or > > not. We already have some linux-specific flights which suppress most > > of the jobs. Maybe it would be better done with some ifs in the > > existing script, or something. > > Aha, I was forgetting about those... So, just to check if I'm > understanding correctly, you mean, as far as make-flight is concerned, a > $branch. E.g, a 'fedora' branch, as we have a 'linux-next' branch, > right? Yes. However it's done, from the pov of the database and the cron jobs it would probably be a new $branch, but that doesn't mean it can't have a new script. I don't have a fixed opinion about whether ifs in make-flight are the right approach, compared to a separate script. You should pick for yourself the one that makes the code smaller and/or less complicated :-). Thanks, Ian.