From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [OSSTest PATCH [RFC] 2/4] ts-fedora-install: added for installing fedora guests Date: Fri, 13 Dec 2013 18:24:57 +0000 Message-ID: <21163.20729.196942.885459@mariner.uk.xensource.com> References: <20131212221933.11164.46804.stgit@Solace> <20131212225332.11164.99188.stgit@Solace> <21163.14674.870408.97251@mariner.uk.xensource.com> <1386958374.3980.42.camel@Solace> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1386958374.3980.42.camel@Solace> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Dario Faggioli writes ("Re: [Xen-devel] [OSSTest PATCH [RFC] 2/4] ts-fedora-install: added for installing fedora guests"): > On ven, 2013-12-13 at 16:44 +0000, Ian Jackson wrote: > > I'm not sure I like this kind of downloading of test OS code for each > > platform. This is sustainable for one distro (the Debian which most of > > our tests use), but if we need to maintain a local mirror for every > > test target OS the infrastructure is going to be a royal pain to > > maintain. And we'll be exposed to a much wider range of failures > > which will cause spurious test failures. This surely applies to > > release images - couldn't they just be stored in the osstest images > > directory ? > > > I'm not sure what "osstest images directory" is; I'll check. What I care > is for these jobs to keep being usable in standalone mode, if going that > way is not a problem wrt that, I think I can. I mean $c{Images}. You could provide a script (mg-download-fedora) to download/update them. > Also, this are not .iso or disk images, they're just a kernel and a > ramdisk, but I guess that does not make much of a difference. Indeed. The debian-installer stuff goes in /tftpboot but is handled much the way I'm suggesting. > I'll check what RH testcases do, as well as what Roger did for FreeBSD, > as I remember seeing something about downloading images and storing them > in the proper place in those patches too. Right. > > You shouldn't use /tmp really like this. Please use a > > flight-and-job-specific directory in ~. > > And that would be for the sake of keeping the installer's kernel and > initrd and have them archived together with the logs? No, it's because in the future I want to be able to run multiple test jobs on a single host, so the pathnames oughtn't to be fixed. And there is no good reason for using /tmp here. /tmp has a number of problems (many of which don't apply here, admittedly) so it's not a good habit to use it. We're talking about paths on the test host dom0 here, right ? > Ok, I'll see if I can factor a bit more (valid also for the other > comments that were expressed below this point for this patch). Thanks, Ian.