From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [Patch v2 3/4] tools/xenstored: Avoid buffer
	overflows while setting up sockets [and 1 more messages]
Date: Fri, 13 Dec 2013 18:28:08 +0000
Message-ID: <21163.20920.529172.797714@mariner.uk.xensource.com>
References: <CAD3CanccryKjcUDJ21sm6LJ75dv8JmPi8BRNuzpF2jwLsZ_Y-Q@mail.gmail.com>
	<1385390321-10124-1-git-send-email-andrew.cooper3@citrix.com>
	<529C88AC.5070706@citrix.com> <52A5C659.4040902@citrix.com>
	<52AB4E44.9060309@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1385390321-10124-1-git-send-email-andrew.cooper3@citrix.com>,
	<52AB4E44.9060309@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Matthew Daley <mattd@bugfuzz.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Andrew Cooper writes ("[Xen-devel] [Patch v2 3/4] tools/xenstored: Avoid buffer overflows while setting up sockets"):
> Coverity ID: 1055996 1056002
> 
> Cache the xs_daemon_socket{,_ro}() strings to save pointlessly
> re-snprintf()'ing the same path, and add explicit size checks against
> addr.sun_path before strcpy()'ing into it.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Matthew Daley <mattd@bugfuzz.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>

Andrew Cooper writes ("Re: [Xen-devel] [Patch v2 3/4] tools/xenstored: Avoid buffer overflows while setting up sockets"):
> Given the spirit today of missed pings on patches,
> 
> Third time lucky?

Sorry about that.  (Coverity is generating a lot of very similar
patches; in this case I had confused this one in my mind with
f220279c14 which you even mention in the commit message.)

Thanks for chasing.

Ian.