From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: Seung-Woo Kim <sw0312.kim@samsung.com>,
dri-devel@lists.freedesktop.org, inki.dae@samsung.com,
emil.l.velikov@gmail.com
Cc: robclark@freedesktop.org
Subject: Re: [PATCH libdrm 1/3] exynos: fix type-punned pointer build warning
Date: Fri, 31 Mar 2017 11:58:02 +0200 [thread overview]
Message-ID: <21174674-067d-f035-9009-c90f92c448b1@math.uni-bielefeld.de> (raw)
In-Reply-To: <1490931057-30853-2-git-send-email-sw0312.kim@samsung.com>
Hello Seung-Woo,
Reviewed-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
With best wishes,
Tobias
Seung-Woo Kim wrote:
> As like the commit ecc2a097294d ("xf86drm: Fix type-punned pointer
> build warning"), this fixes following build warning.
>
> exynos_drm.c: In function 'exynos_handle_event':
> exynos_drm.c:420:15: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
> e = (struct drm_event *) &buffer[i];
> ^
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> exynos/exynos_drm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/exynos/exynos_drm.c b/exynos/exynos_drm.c
> index b961e52..f6204f1 100644
> --- a/exynos/exynos_drm.c
> +++ b/exynos/exynos_drm.c
> @@ -417,7 +417,7 @@ exynos_handle_event(struct exynos_device *dev, struct exynos_event_context *ctx)
>
> i = 0;
> while (i < len) {
> - e = (struct drm_event *) &buffer[i];
> + e = (struct drm_event *)(buffer + i);
> switch (e->type) {
> case DRM_EVENT_VBLANK:
> if (evctx->version < 1 ||
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-03-31 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170331033036epcas5p40d5c3f7244c93cf9b3088e27b53ec9db@epcas5p4.samsung.com>
2017-03-31 3:30 ` [PATCH libdrm 0/3] remove build warnings for exynos Seung-Woo Kim
[not found] ` <CGME20170331033036epcas5p43ab05758c1a16c8b754d65b5d8578c43@epcas5p4.samsung.com>
2017-03-31 3:30 ` [PATCH libdrm 1/3] exynos: fix type-punned pointer build warning Seung-Woo Kim
2017-03-31 9:58 ` Tobias Jakobi [this message]
[not found] ` <CGME20170331033036epcas5p48e6a32ec3de74fa6f3101476d1c43bef@epcas5p4.samsung.com>
2017-03-31 3:30 ` [PATCH libdrm 2/3] exynos/fimg2d: remove unused-function " Seung-Woo Kim
2017-03-31 9:56 ` Tobias Jakobi
[not found] ` <CGME20170331033037epcas5p461fb6bc9ee12cfc2247a3ab4481aaf54@epcas5p4.samsung.com>
2017-03-31 3:30 ` [PATCH libdrm 3/3] tests/exynos: " Seung-Woo Kim
2017-04-03 16:28 ` [PATCH libdrm 0/3] remove build warnings for exynos Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21174674-067d-f035-9009-c90f92c448b1@math.uni-bielefeld.de \
--to=tjakobi@math.uni-bielefeld.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=inki.dae@samsung.com \
--cc=robclark@freedesktop.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.