From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shuai Ruan <shuai.ruan@linux.intel.com>
Subject: Re: Error booting Xen
Date: Wed, 3 Feb 2016 15:56:57 +0800
Message-ID: <21181.7751908258$1454486426@news.gmane.org>
References: <1453215095.11427.144.camel@citrix.com>
	<569E5118.4030704@citrix.com>
	<CAPtdW14duUx7T6D26sUnZ0m1Cb8gW=p_oL4YAZ3rZbNhU2MbXQ@mail.gmail.com>
	<569E76B102000078000C8C14@prv-mh.provo.novell.com>
	<569E6C36.3070402@citrix.com>
	<1453223282.11427.149.camel@citrix.com>
	<CAPtdW14HFrHN8ywa-HwibVkQtfUs1YXGUKmbEiMS5xgY4cTohw@mail.gmail.com>
	<569F6A2102000078000C8F20@prv-mh.provo.novell.com>
	<20160202044349.GA3036@shuai.ruan@linux.intel.com>
	<56B0874D.1030508@citrix.com>
Reply-To: Shuai Ruan <shuai.ruan@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <56B0874D.1030508@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Dario Faggioli <dario.faggioli@citrix.com>, Harmandeep Kaur <write.harmandeep@gmail.com>, Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, Feb 02, 2016 at 10:39:09AM +0000, Andrew Cooper wrote:
> On 02/02/16 04:43, Shuai Ruan wrote:
> >
> >>> I tried booting staging branch but results were identical. Following
> >>> line repeats endlessly.
> >>> (XEN) traps.c:3290: GPF (0000): ffff82d0801c1cce -> ffff82d080252e5c
> >>>
> >>> $ 'addr2line -e xen-syms ffff82d0801c1cce' returns
> >>> 'xen/xen/arch/x86/xstate.c:387' which again points to
> >>> xsave. Also, adding 'xsave=0' makes it boot just fine.
> >> Ah, I think I see the issue: We're zeroing the entire save area in
> >> the fixup code, which will make XRSTORS fault unconditionally.
> >> Shuai, would you please look into possible ways of fixing this?
> > Ok. I will look into this problem.
> 
> Fixes for this have been committed already.  changesets 104a409^..d570d82
> 
> It would be useful if you could review them to see if there are any
> issues Jan and myself missed.
The patch is ok to me. 
And I test it on the skylake machine (with xsaves support), no boot error happen.

Thanks
> 
> ~Andrew
>