From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Phillip Potter <phil@philpotter.co.uk>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove unnecessary ret variable in rtw_drv_init()
Date: Mon, 16 Aug 2021 12:15:56 +0200 [thread overview]
Message-ID: <2121129.EM0CHCvl88@localhost.localdomain> (raw)
In-Reply-To: <20210816090500.GG1931@kadam>
On Monday, August 16, 2021 11:05:00 AM CEST Dan Carpenter wrote:
> To be honest, I prefered the original.
>
> foo = alloc();
> if (!foo) {
> ret = -EWHATEVER;
> goto free_last_thing;
> }
>
> I like this style of error handling because all the information is
> there. You don't need to scroll down.
>
Thinking deeper about this style of error handling, I find that Dan is quite
right in preferring readability over removal of (technically unnecessary)
temporary variables. Perhaps the trade-off between brevity and readability
should (in general) favor the latter.
Furthermore, those temporary variables make the code easily adaptable/
extensible in cases where, in future revisions of the code, there will be more
different errors to handle.
However, it's mainly a matter of style, so...
>
> I don't really care about this specific patch at all. It's a small
> thing. But we had someone come through who was sort of obsessed with
> removing these sorts of variables. Just because you can remove a
> variable doesn't necessarily make the code more readable.
>
> If you're doing the work and maintaining the driver you get to choose
> your own style to some extent.
>
I agree: choose your own style (to some extent).
Thanks,
Fabio
>
> But I don't want to encourage people to
> start sending these sort of patches more generally.
>
> regards,
> dan carpenter
prev parent reply other threads:[~2021-08-16 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 20:14 [PATCH] staging: r8188eu: Remove unnecessary ret variable in rtw_drv_init() Nathan Chancellor
2021-08-13 21:55 ` Fabio M. De Francesco
2021-08-14 17:16 ` Phillip Potter
2021-08-14 17:16 ` Phillip Potter
2021-08-16 9:05 ` Dan Carpenter
2021-08-16 10:15 ` Fabio M. De Francesco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2121129.EM0CHCvl88@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.