All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Olaf Hering <olaf@aepfle.de>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: missing dependency on libxlu_disk_l.h
Date: Tue, 18 Feb 2014 11:35:05 +0000	[thread overview]
Message-ID: <21251.17769.656791.139815@mariner.uk.xensource.com> (raw)
In-Reply-To: <1392718729.11080.13.camel@kazak.uk.xensource.com>

Ian Campbell writes ("Re: [Xen-devel] missing dependency on libxlu_disk_l.h"):
> On Sat, 2014-02-15 at 23:17 +0100, Olaf Hering wrote:
> > I'm not sure if libxlu_disk_l.h is a generated file.
> 
> It is, but we also check in the generated version, IIRC due to a bug in
> some versions of flex, but also partially for convenience to avoid the
> need for flex on all development systems.

Right.

> >  But just once I saw
> > this failure below with automated build and make -j 16. This source tree
> > has the discard-enable patch, which changes tools/libxl/libxlu_disk_l.l.
> > As a result libxlu_disk_l.c is regenerated, see the flex call below.
> 
> It might be a good idea to either also patch the generated files or to
> have the patch remove them, to avoid any possible confusion due to skew.

This ought to be taken care of by the build system, provided you don't
actually git commit only the change to .l and not the change to .[ch].
In the final patch.

> > How should make become aware of the libxlu_disk_l.h dependency?
> 
> I think it would probably need explicitly specifying like we do for the
> IDL generated files.

There is already a place to put this.  See diff below.  Sorry for not
doing this at the time.

> What deleted that file though?

make might have done.

Olaf, can you test whether this diff makes the problem go away for you ?

Thanks,
Ian.

diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index dab2929..755b666 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -98,7 +98,7 @@ TEST_PROGS += $(foreach t, $(LIBXL_TESTS),test_$t)
 $(LIBXL_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
 
 AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h \
-	_libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
+	libxlu_disk_l.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
 AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
 AUTOSRCS += _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
 LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \

  reply	other threads:[~2014-02-18 11:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15 22:17 missing dependency on libxlu_disk_l.h Olaf Hering
2014-02-18 10:18 ` Ian Campbell
2014-02-18 11:35   ` Ian Jackson [this message]
2014-02-18 13:56     ` Olaf Hering
2014-02-18 14:21       ` Olaf Hering
2014-02-18 14:53       ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21251.17769.656791.139815@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=olaf@aepfle.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.