From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 1/3] eal/vfio: add support for multiple
	container
Date: Wed, 21 Mar 2018 21:32:18 +0100
Message-ID: <2126445.Z7b39kXXoB@xps>
References: <20180309230809.63361-3-xiao.w.wang@intel.com>
 <20180321132108.52464-1-xiao.w.wang@intel.com>
 <20180321132108.52464-2-xiao.w.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, yliu@fridaylinux.org,
 zhihong.wang@intel.com, tiwei.bie@intel.com, rosen.xu@intel.com,
 dan.daly@intel.com, cunming.liang@intel.com, anatoly.burakov@intel.com,
 gaetan.rivet@6wind.com
To: Xiao Wang <xiao.w.wang@intel.com>, junjie.j.chen@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id F30617CDA
 for <dev@dpdk.org>; Wed, 21 Mar 2018 21:32:34 +0100 (CET)
In-Reply-To: <20180321132108.52464-2-xiao.w.wang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

21/03/2018 14:21, Xiao Wang:
> +#endif /* VFIO_PRESENT */
>  #endif /* _RTE_VFIO_H_ */

Please keep the empty line which was present between endif.

> +	rte_vfio_create_container;
> +	rte_vfio_destroy_container;
> +	rte_vfio_bind_group_no;
> +	rte_vfio_unbind_group_no;
> +	rte_vfio_dma_map;
> +	rte_vfio_dma_unmap;
> +	rte_vfio_get_group_fd;

Please keep alphabetical order.

About the naming, I see "no" and "idx" are used.
Other APIs in DPDK are using "num" and "id". Any strong opinion?