From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH V4 03/12] TestSupport.pm: move
	rewrite_config_nocd to support library
Date: Wed, 2 Apr 2014 17:04:44 +0100
Message-ID: <21308.13596.556422.321870@mariner.uk.xensource.com>
References: <1395418466-6997-1-git-send-email-wei.liu2@citrix.com>
	<1395418466-6997-4-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1395418466-6997-4-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Wei Liu writes ("[PATCH V4 03/12] TestSupport.pm: move rewrite_config_nocd to support library"):
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

This should probably have a better name if it's going to be in there.
guest_blah_blah_something.  guest_editconfig_nocd perhaps ?  Unless
you have a better idea.

Also it can probably use $gho->{Host} rather than taking $ho
explicitly.

Thanks,
Ian.