From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH V4 06/12] TestSupport.pm: introduce
	create_empty_iso
Date: Wed, 2 Apr 2014 17:08:04 +0100
Message-ID: <21308.13796.966005.402092@mariner.uk.xensource.com>
References: <1395418466-6997-1-git-send-email-wei.liu2@citrix.com>
	<1395418466-6997-7-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1395418466-6997-7-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Wei Liu writes ("[PATCH V4 06/12] TestSupport.pm: introduce create_empty_iso"):
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
...
> +sub create_empty_iso($$$) {
> +    my ($ho,$emptyiso,$emptydir) = @_;
> +    my @isogen_opts= qw(-as mkisofs -R -J);
> +
> +    # Unfortunately xorriso refuses to create an ISO if the input
> +    # directory is empty.

How annoying.

> +    target_cmd_root($ho, <<END, 60);
> +        mkdir -p $emptydir
> +        echo empty > $emptydir/empty
> +END

Isn't this a duplicate of the code in ts-redhat-install ?

Ian.