From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH V4 08/12] TestSupport.pm: introduce
	copy_iso_content_to_dir
Date: Wed, 2 Apr 2014 17:10:52 +0100
Message-ID: <21308.13964.426362.827214@mariner.uk.xensource.com>
References: <1395418466-6997-1-git-send-email-wei.liu2@citrix.com>
	<1395418466-6997-9-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1395418466-6997-9-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Wei Liu writes ("[PATCH V4 08/12] TestSupport.pm: introduce copy_iso_content_to_dir"):
> ... which returns a string of commands to pass into target_cmd_root.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Although I'm starting to wonder about the names here:

>                        create_iso_xorriso
>                        create_empty_iso
>                        iso_gen_flags_basic
> +                      copy_iso_content_to_dir
>                        rewrite_config_nocd

Maybe some of these should be called   iso_create_xorriso
iso_create_empty  etc.

And maybe this one

> +sub copy_iso_content_to_dir($$) {
> +    my ($gho,$newiso) = @_;
> +    return <<"END";
> +            set -ex
> +            umount /mnt ||:
> +            rm -rf $newiso
> +            mount -o loop -r $gho->{Rimage} /mnt

should mention the word "image" in its name.  Eg
"iso_copy_content_from_image" or something.

Let me know what you think.

Thanks,
Ian.