From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH V4 04/12] TestSupport.pm: introduce
	guest_create
Date: Thu, 3 Apr 2014 15:15:32 +0100
Message-ID: <21309.27908.412937.293751@mariner.uk.xensource.com>
References: <1395418466-6997-1-git-send-email-wei.liu2@citrix.com>
	<1395418466-6997-5-git-send-email-wei.liu2@citrix.com>
	<21308.13698.377809.917360@mariner.uk.xensource.com>
	<20140402175303.GK6382@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20140402175303.GK6382@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Wei Liu writes ("Re: [PATCH V4 04/12] TestSupport.pm: introduce guest_create"):
> On Wed, Apr 02, 2014 at 05:06:26PM +0100, Ian Jackson wrote:
> > Wei Liu writes ("[PATCH V4 04/12] TestSupport.pm: introduce guest_create"):
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > 
> > > +sub guest_create ($$$) {
> > > +    my ($ho,$gho,$toolstack) = @_;
> > > +    target_cmd_root($ho, "$toolstack create $gho->{CfgPath}", 100);
> > > +}
> > > +
> > 
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> Actually $ho can be replaced with $gho->{Host}, just as you suggested in
> previous patch.
> 
> Since this is only mechanical change, I will retain your ack, if this is
> OK.

Sure.

Ian.