From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from mx1.yrkesakademin.fi ([85.134.45.194]:48783 "EHLO
        mx1.yrkesakademin.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754850AbdKNL3e (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Tue, 14 Nov 2017 06:29:34 -0500
Subject: Re: [PATCH] iwlwifi: fix firmware names for 9xxx and a0 series hw
To: Luca Coelho <luciano.coelho@intel.com>,
        <linux-wireless@vger.kernel.org>
CC: <stable@vger.kernel.org>
References: <20171114103751.7761-1-tmb@mageia.org>
 <1510656721.4011.87.camel@coelho.fi>
From: Thomas Backlund <tmb@mageia.org>
Message-ID: <2131d658-8a6e-2f3b-4e44-a3206385af46@mageia.org> (sfid-20171114_122946_804272_1D09D966)
Date: Tue, 14 Nov 2017 13:29:01 +0200
MIME-Version: 1.0
In-Reply-To: <1510656721.4011.87.camel@coelho.fi>
Content-Type: text/plain; charset="utf-8"; format=flowed
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

Den 14-11-2017 kl. 12:52, skrev Luca Coelho:
> On Tue, 2017-11-14 at 12:37 +0200, Thomas Backlund wrote:
>> iwlwifi 9xxx and a0 series hw contains an extra dash in firmware file
>> name
>> as seeen in modinfo output for kernel 4.14:
>>
>> firmware:       iwlwifi-9260-th-b0-jf-b0--34.ucode
>> firmware:       iwlwifi-9260-th-a0-jf-a0--34.ucode
>> firmware:       iwlwifi-9000-pu-a0-jf-b0--34.ucode
>> firmware:       iwlwifi-9000-pu-a0-jf-a0--34.ucode
>> firmware:       iwlwifi-QuQnj-a0-hr-a0--34.ucode
>> firmware:       iwlwifi-QuQnj-a0-jf-b0--34.ucode
>> firmware:       iwlwifi-QuQnj-f0-hr-a0--34.ucode
>> firmware:       iwlwifi-Qu-a0-jf-b0--34.ucode
>> firmware:       iwlwifi-Qu-a0-hr-a0--34.ucode
>>
>> Fix that by dropping the extra adding of '"-"'.
>>
>> Signed-off-by: Thomas Backlund <tmb-odJJhXpcy38dnm+yROfE0A@public.gmane.org>
>> cc: Luca Coelho <luciano.coelho-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>> cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>
>> ---
> 
> Looks good, thanks!
> 
> Though I'm not sure this is worth sending to stable... Why do you think
> it's needed?
> 

As 4.14 is a -longterm kernel and afaik atleast 9xxx series hw is out 
there I thought it would be good to have it fixed there...

but in the end it's your call for upstream stable or not

I'll add it to the Mageia distrib kernels anyway.

> Anyway, I'm applying it in our internal tree and it will reach the
> mainline following our normal upstreaming process.
> 

Thanks.

> --
> Cheers,
> Luca.
> 

--
Thomas