From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64CD5C433F5 for ; Wed, 9 Mar 2022 22:39:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7F2611836; Wed, 9 Mar 2022 23:38:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7F2611836 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646865586; bh=IfVPdKhS4QZ5fdjxK7CDIclXFb1vUgQyUNprq6qyH7w=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iikvWXIk6V0JeQCOIJjZXENZGXQsqcbjtHPNgrneFcS4oc/4/JiyCZyg1jRwH/3S/ 4b2c2B2JhhEpnVShJLFRY7UxDZAMy7V0CqVLhw3zK5GMPHmq4CYllrwbMrc2J2XKu0 D+8cTDrPpY5NmFvBLdBu9ELbwsPVfbm5ue/X7EK8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 463C0F80524; Wed, 9 Mar 2022 23:37:43 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F250BF8051E; Wed, 9 Mar 2022 23:37:39 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0F846F80508 for ; Wed, 9 Mar 2022 23:37:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0F846F80508 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fsR0mWKz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646865458; x=1678401458; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=IfVPdKhS4QZ5fdjxK7CDIclXFb1vUgQyUNprq6qyH7w=; b=fsR0mWKzppybs+NBYbqG2Y8v8O+EYKyQ8QTFxh+6mGzfmICkJjnlcwJo cjGKEBPEmsuGYsGnYost559lXgRUbh4S8cyagaT8NW2FefRhCe1KBcL3t GWnF5d6YYTkc3f+qTUg4iQ1aqavRVwEBvqaMz5Y7L2ZwulBlCzR9o1ORM /BKDJPyt1IzUCuYXlP5CBZkZEl+6zBr5dNG/R+rnS+qIL//Tpv9+UKmhx BBJ5vTJbu38A0H3vO/mQXqX9Ub1oO5azt0rcXlpSKQs7bJAh2EiR9tBq+ 2/x94EHgdC6v+C2vj6Bxi4PWLiDlfMorL7w5dzvaLIF+oT/HQwh7hZEVl A==; X-IronPort-AV: E=McAfee;i="6200,9189,10281"; a="279840331" X-IronPort-AV: E=Sophos;i="5.90,168,1643702400"; d="scan'208";a="279840331" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2022 14:37:31 -0800 X-IronPort-AV: E=Sophos;i="5.90,168,1643702400"; d="scan'208";a="688449514" Received: from nhaouati-mobl2.amr.corp.intel.com (HELO [10.212.216.252]) ([10.212.216.252]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2022 14:37:27 -0800 Message-ID: <21355731-115b-5b8b-fe19-51e82cc6ae2a@linux.intel.com> Date: Wed, 9 Mar 2022 16:20:26 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [PATCH v4 10/17] ASoC: Intel: avs: Add basefw runtime-parameter requests Content-Language: en-US To: Cezary Rojewski , alsa-devel@alsa-project.org References: <20220309204029.89040-1-cezary.rojewski@intel.com> <20220309204029.89040-11-cezary.rojewski@intel.com> From: Pierre-Louis Bossart In-Reply-To: <20220309204029.89040-11-cezary.rojewski@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: upstream@semihalf.com, harshapriya.n@intel.com, rad@semihalf.com, tiwai@suse.com, hdegoede@redhat.com, broonie@kernel.org, ranjani.sridharan@linux.intel.com, amadeuszx.slawinski@linux.intel.com, cujomalainey@chromium.org, lma@semihalf.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > +enum avs_i2s_version { > + AVS_I2S_VER_15_SKYLAKE = 0x00000, > + AVS_I2S_VER_15_BROXTON = 0x10000, I would add a comment that this is added for completeness but not tested/supported. > + AVS_I2S_VER_15_BROXTON_P = 0x20000, > + AVS_I2S_VER_18_KBL_CNL = 0x30000, > +};