From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E2D9C61DA4 for ; Tue, 14 Feb 2023 06:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231717AbjBNGxz (ORCPT ); Tue, 14 Feb 2023 01:53:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbjBNGxy (ORCPT ); Tue, 14 Feb 2023 01:53:54 -0500 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EB6E974F for ; Mon, 13 Feb 2023 22:53:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676357632; x=1707893632; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vJT5yR/Sn8DOqFnUb6p/yV160A1yTRb/rLOfRM6M9Vo=; b=p9jP3IE6MmBizSgt+u/KT69C9rqy45XWbqWqgUOBIwAvjUCu72SEtEjk MK8hgDabogmUuzbWwDut/WRyhV51kfcYY8yjLAGEcsYVx/Jz3I6JGqKk6 qZghwypw4yFXACLXGYUkLBYHf/6WabaG2+8fmItpRbbLf7ZuovM1HU7kA IwNlqFlB903HVRgX0QtoaTO3F6o3Zvqbsl+wX2+Onxiqx5o6pne31gKs0 qbOL9KstKH/9/Z+ekAZA+i6zpj4/Dn2DeUN+bejGND56M8N9MtlBKRcZa lo4q/dKoFFOkAYmfiV/1EXC+LITzIsuKPcIWpL5nQ1l30IhHa9OiA2VDX A==; X-IronPort-AV: E=Sophos;i="5.97,294,1669071600"; d="scan'208";a="29058498" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 14 Feb 2023 07:53:50 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 14 Feb 2023 07:53:50 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 14 Feb 2023 07:53:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676357630; x=1707893630; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vJT5yR/Sn8DOqFnUb6p/yV160A1yTRb/rLOfRM6M9Vo=; b=KT3PdX3r594pHAAdeidlcCQgIyvgp0HnR/RkcNfoFjGcljyhk9qH2/2i qJuyv3mfYtKbsConV2Fz7rpPrwqMjlS4heZgUmvz+1/+jPxJtL7C8KCCz 7fHHC1KCdNkTtps9kBdvONhtMboQQkgNHB441PQjtwhwZFr7Db5rEZ2cU 99Q8FcUueVpwVza0IlbnxwEYtUZUliOMdqXuP+hUPwH/P4KxLPww3/2RP 3oPewihV4Y46SJdcFLRAuqrhdS+9lT2jr+XmGqPhWakedqVfnNioxc4e1 W04iE7YwY/nHhlV0mqvJwxXLXq2CWr+PDr+o34C6VRYnFSH3IREiFmujz A==; X-IronPort-AV: E=Sophos;i="5.97,294,1669071600"; d="scan'208";a="29058496" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 14 Feb 2023 07:53:50 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 39073280056; Tue, 14 Feb 2023 07:53:50 +0100 (CET) From: Alexander Stein To: Dong Aisheng , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team Cc: Pengutronix Kernel Team , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] i2c: imx-lpi2c: clean rx/tx buffers upon new message Date: Tue, 14 Feb 2023 07:53:48 +0100 Message-ID: <2137650.irdbgypaU6@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230130153247.445027-1-alexander.stein@ew.tq-group.com> References: <20230130153247.445027-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi, any feedback on this series? Best regards, Alexander Am Montag, 30. Januar 2023, 16:32:46 CET schrieb Alexander Stein: > When start sending a new message clear the Rx & Tx buffer pointers in > order to avoid using stale pointers. >=20 > Signed-off-by: Alexander Stein > --- > I noticed an ambigous stack corruption once my rtc-pcf85063 driver probes. >=20 > [ 2.695684] Kernel panic - not syncing: stack-protector: Kernel stack = is > corrupted in: pcf85063_rtc_read_time+0x10/0x100 [ 2.706669] CPU: 1 PID: > 63 Comm: kworker/u8:2 Not tainted 6.2.0-rc6-next-20230130+ #1185 > ca067559321ae817c063baccdba80d328f10f73 [ 2.718331] Hardware name: > TQ-Systems i.MX8QXP TQMa8XQP on MBa8Xx (DT) [ 2.724866] Workqueue: > events_unbound deferred_probe_work_func > [ 2.730712] Call trace: > [ 2.733161] dump_backtrace+0x9c/0x11c > [ 2.736914] show_stack+0x14/0x1c > [ 2.740232] dump_stack_lvl+0x5c/0x78 > [ 2.743907] dump_stack+0x14/0x1c > [ 2.747225] panic+0x34c/0x39c > [ 2.750283] __ktime_get_real_seconds+0x0/0xc > [ 2.754653] pcf85063_ioctl+0x0/0xf0 > [ 2.758232] __rtc_read_time+0x44/0x114 > [ 2.762081] __rtc_read_alarm+0x258/0x460 > [ 2.766095] __devm_rtc_register_device+0x174/0x2b4 > [ 2.770986] pcf85063_probe+0x258/0x4d4 > [ 2.774825] i2c_device_probe+0x100/0x33c >=20 > The backtrace did not indicate the actual cause of it. Checking the code = the > RTC driver seemed to be ok, so it has to be in the i2c bus driver. At some > point I noticed that I see both Rx and Tx interrupts at the same time, > which is odd. Also both rx_buf and tx_buf was set simultaneously. Clearly= a > bug to me. > Clearing the buffer pointers upon each new i2c message triggered a NULL > pointer dereference: >=20 > [ 2.694923] Unable to handle kernel NULL pointer dereference at virtual > address 0000000000000001 [ 2.703730] Mem abort info: > [ 2.706525] ESR =3D 0x0000000096000004 > [ 2.710278] EC =3D 0x25: DABT (current EL), IL =3D 32 bits > [ 2.715595] SET =3D 0, FnV =3D 0 > [ 2.718653] EA =3D 0, S1PTW =3D 0 > [ 2.721798] FSC =3D 0x04: level 0 translation fault > [ 2.726680] Data abort info: > [ 2.729556] ISV =3D 0, ISS =3D 0x00000004 > [ 2.733387] CM =3D 0, WnR =3D 0 > [ 2.736358] [0000000000000001] user address but active_mm is swapper > [ 2.742719] Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP > [ 2.748990] Modules linked in: > [ 2.752051] CPU: 0 PID: 0 Comm: swapper/0 Not tainted > 6.2.0-rc6-next-20230130+ #1184 44a8abebca6bfabc93e20ac52bce 47da7f92cec1 > [ 2.763368] Hardware name: TQ-Systems i.MX8QXP TQMa8XQP on MBa8Xx (DT) > [ 2.769902] pstate: 800000c5 (Nzcv daIF -PAN -UAO -TCO -DIT -SSBS > BTYPE=3D--) [ 2.776868] pc : lpi2c_imx_write_txfifo+0x44/0xb0 > [ 2.781585] lr : lpi2c_imx_isr+0x60/0x8c > [ 2.785512] sp : ffff800008003ef0 > [ 2.788831] x29: ffff800008003ef0 x28: ffff8000099c1ec0 x27: > 00000000bfe632c8 [ 2.795980] x26: 0000000000000000 x25: ffff800009b935= ed > x24: ffff800009a4d4c0 [ 2.803130] x23: ffff00000365e800 x22: > 0000000000000128 x21: 0000000000000000 [ 2.810280] x20: ffff0000033f40= 80 > x19: 0000000003000103 x18: 0000000000000000 [ 2.817430] x17: > ffff80003688a000 x16: ffff800008000000 x15: 0000000000000000 [ 2.82457= 9] > x14: 0000000000000000 x13: ffff8000099d1db8 x12: 0000000000000000 [ =20 > 2.831729] x11: ffff800009503180 x10: 0000000000000a80 x9 : ffff8000099b3d= 20 > [ 2.838879] x8 : ffff8000099c29a0 x7 : 00000000000000c0 x6 : > ffff000002838028 [ 2.846029] x5 : 0000000000000002 x4 : 00000000000000= 00 > x3 : 0000000000000000 [ 2.849626] imx-scu system-controller: RPC send > msg timeout > [ 2.853178] x2 : ffff800009c88060 x1 : 0000000000000001 x0 : > ffff0000033f4080 [ 2.858764] enet1: failed to power off resource 252 > ret -110 > [ 2.865897] Call trace: > [ 2.865901] lpi2c_imx_write_txfifo+0x44/0xb0 > [ 2.878443] __handle_irq_event_percpu+0x5c/0x188 > [ 2.883151] handle_irq_event+0x48/0xb0 >=20 > $ ./scripts/faddr2line build_arm64/vmlinux lpi2c_imx_write_txfifo+0x44/0x= b0 > lpi2c_imx_write_txfifo+0x44/0xb0: > lpi2c_imx_write_txfifo at drivers/i2c/busses/i2c-imx-lpi2c.c:364 >=20 > This now clearly pinpoints the wrong access which previously corrupted the > stack. The error leading to this wrong access is addressed in the > following patch. >=20 > drivers/i2c/busses/i2c-imx-lpi2c.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c > b/drivers/i2c/busses/i2c-imx-lpi2c.c index 188f2a36d2fd..c6d0225246e6 > 100644 > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c > @@ -463,6 +463,8 @@ static int lpi2c_imx_xfer(struct i2c_adapter *adapter, > if (num =3D=3D 1 && msgs[0].len =3D=3D 0) > goto stop; >=20 > + lpi2c_imx->rx_buf =3D NULL; > + lpi2c_imx->tx_buf =3D NULL; > lpi2c_imx->delivered =3D 0; > lpi2c_imx->msglen =3D msgs[i].len; > init_completion(&lpi2c_imx->complete); =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6DAFC61DA4 for ; Tue, 14 Feb 2023 06:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+IMZhRLbiCmJrbmJAwKiJooamvMY7gGAPt+azrzteCs=; b=q+6Q0O9roSc0K7 Ms0NUhfnW3Q9mpSxpEnE15lHLNdKao32/8Gx3IIUAI9l0nGMspB8VPtKusTceKwQgaxkWKI279CNz 7DqqiK1cHjf+AnL9Qfs3O5kJWVrOD/BDtNMdKQcQh5Zn3wdI2Zx2SdjqG1OKFzcKhlZnkcQ0vZL/D F2v4h3NTrjv+rScC2lXgNpcIr8r/M9eRGht8BkRrjY4xGL8dZZrxiQdQT1aaGlVorb/y+ol7o+n9C G8JWVNH12IbX53atW5KBDY5LLxAjzEY/B3L9hRyRmjxNZZ7H+d/GlmrtFfVNx0EfvH/u1MmaxCeM5 0MwljqApTgzCeLYaJjsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRpCQ-0005xF-SX; Tue, 14 Feb 2023 06:53:59 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRpCN-0005wb-8q for linux-arm-kernel@lists.infradead.org; Tue, 14 Feb 2023 06:53:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676357635; x=1707893635; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vJT5yR/Sn8DOqFnUb6p/yV160A1yTRb/rLOfRM6M9Vo=; b=iNjJnQ5/nEropARwDNcQmYzaPgLLx+UwzzO1I6TNQBNBAzO9scFcpzK6 Ym2C++ESrb+KN8M7VC14muPzu6bMyfaESOZ989osD9n0XeMGO8qe4adaS myPuhhz54y4XTY7DkbYoupv7n3lQM76Cdsd2kJp3EfA9EjY9Oaa+ssiRH YFe0GhpLumvoHqow7fCGN+LowGLz3EdquoqWcP9b2JPShjZ8okh+SoIrw 1oKt9KvRr/20jrCYCHu3EK49i6NFq5ahDOWowHIBrv9qVf87Pk8ShC+zj os/mhbNwzqNWhO2s6qufOGTrOZMeRA51EOomd56NY7JnOHBqSwR4mAyfg A==; X-IronPort-AV: E=Sophos;i="5.97,294,1669071600"; d="scan'208";a="29058498" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 14 Feb 2023 07:53:50 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 14 Feb 2023 07:53:50 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 14 Feb 2023 07:53:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676357630; x=1707893630; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vJT5yR/Sn8DOqFnUb6p/yV160A1yTRb/rLOfRM6M9Vo=; b=KT3PdX3r594pHAAdeidlcCQgIyvgp0HnR/RkcNfoFjGcljyhk9qH2/2i qJuyv3mfYtKbsConV2Fz7rpPrwqMjlS4heZgUmvz+1/+jPxJtL7C8KCCz 7fHHC1KCdNkTtps9kBdvONhtMboQQkgNHB441PQjtwhwZFr7Db5rEZ2cU 99Q8FcUueVpwVza0IlbnxwEYtUZUliOMdqXuP+hUPwH/P4KxLPww3/2RP 3oPewihV4Y46SJdcFLRAuqrhdS+9lT2jr+XmGqPhWakedqVfnNioxc4e1 W04iE7YwY/nHhlV0mqvJwxXLXq2CWr+PDr+o34C6VRYnFSH3IREiFmujz A==; X-IronPort-AV: E=Sophos;i="5.97,294,1669071600"; d="scan'208";a="29058496" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 14 Feb 2023 07:53:50 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 39073280056; Tue, 14 Feb 2023 07:53:50 +0100 (CET) From: Alexander Stein To: Dong Aisheng , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team Cc: Pengutronix Kernel Team , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] i2c: imx-lpi2c: clean rx/tx buffers upon new message Date: Tue, 14 Feb 2023 07:53:48 +0100 Message-ID: <2137650.irdbgypaU6@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230130153247.445027-1-alexander.stein@ew.tq-group.com> References: <20230130153247.445027-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_225355_741773_2408D758 X-CRM114-Status: GOOD ( 23.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, any feedback on this series? Best regards, Alexander Am Montag, 30. Januar 2023, 16:32:46 CET schrieb Alexander Stein: > When start sending a new message clear the Rx & Tx buffer pointers in > order to avoid using stale pointers. > = > Signed-off-by: Alexander Stein > --- > I noticed an ambigous stack corruption once my rtc-pcf85063 driver probes. > = > [ 2.695684] Kernel panic - not syncing: stack-protector: Kernel stack = is > corrupted in: pcf85063_rtc_read_time+0x10/0x100 [ 2.706669] CPU: 1 PID: > 63 Comm: kworker/u8:2 Not tainted 6.2.0-rc6-next-20230130+ #1185 > ca067559321ae817c063baccdba80d328f10f73 [ 2.718331] Hardware name: > TQ-Systems i.MX8QXP TQMa8XQP on MBa8Xx (DT) [ 2.724866] Workqueue: > events_unbound deferred_probe_work_func > [ 2.730712] Call trace: > [ 2.733161] dump_backtrace+0x9c/0x11c > [ 2.736914] show_stack+0x14/0x1c > [ 2.740232] dump_stack_lvl+0x5c/0x78 > [ 2.743907] dump_stack+0x14/0x1c > [ 2.747225] panic+0x34c/0x39c > [ 2.750283] __ktime_get_real_seconds+0x0/0xc > [ 2.754653] pcf85063_ioctl+0x0/0xf0 > [ 2.758232] __rtc_read_time+0x44/0x114 > [ 2.762081] __rtc_read_alarm+0x258/0x460 > [ 2.766095] __devm_rtc_register_device+0x174/0x2b4 > [ 2.770986] pcf85063_probe+0x258/0x4d4 > [ 2.774825] i2c_device_probe+0x100/0x33c > = > The backtrace did not indicate the actual cause of it. Checking the code = the > RTC driver seemed to be ok, so it has to be in the i2c bus driver. At some > point I noticed that I see both Rx and Tx interrupts at the same time, > which is odd. Also both rx_buf and tx_buf was set simultaneously. Clearly= a > bug to me. > Clearing the buffer pointers upon each new i2c message triggered a NULL > pointer dereference: > = > [ 2.694923] Unable to handle kernel NULL pointer dereference at virtual > address 0000000000000001 [ 2.703730] Mem abort info: > [ 2.706525] ESR =3D 0x0000000096000004 > [ 2.710278] EC =3D 0x25: DABT (current EL), IL =3D 32 bits > [ 2.715595] SET =3D 0, FnV =3D 0 > [ 2.718653] EA =3D 0, S1PTW =3D 0 > [ 2.721798] FSC =3D 0x04: level 0 translation fault > [ 2.726680] Data abort info: > [ 2.729556] ISV =3D 0, ISS =3D 0x00000004 > [ 2.733387] CM =3D 0, WnR =3D 0 > [ 2.736358] [0000000000000001] user address but active_mm is swapper > [ 2.742719] Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP > [ 2.748990] Modules linked in: > [ 2.752051] CPU: 0 PID: 0 Comm: swapper/0 Not tainted > 6.2.0-rc6-next-20230130+ #1184 44a8abebca6bfabc93e20ac52bce 47da7f92cec1 > [ 2.763368] Hardware name: TQ-Systems i.MX8QXP TQMa8XQP on MBa8Xx (DT) > [ 2.769902] pstate: 800000c5 (Nzcv daIF -PAN -UAO -TCO -DIT -SSBS > BTYPE=3D--) [ 2.776868] pc : lpi2c_imx_write_txfifo+0x44/0xb0 > [ 2.781585] lr : lpi2c_imx_isr+0x60/0x8c > [ 2.785512] sp : ffff800008003ef0 > [ 2.788831] x29: ffff800008003ef0 x28: ffff8000099c1ec0 x27: > 00000000bfe632c8 [ 2.795980] x26: 0000000000000000 x25: ffff800009b935= ed > x24: ffff800009a4d4c0 [ 2.803130] x23: ffff00000365e800 x22: > 0000000000000128 x21: 0000000000000000 [ 2.810280] x20: ffff0000033f40= 80 > x19: 0000000003000103 x18: 0000000000000000 [ 2.817430] x17: > ffff80003688a000 x16: ffff800008000000 x15: 0000000000000000 [ 2.82457= 9] > x14: 0000000000000000 x13: ffff8000099d1db8 x12: 0000000000000000 [ = > 2.831729] x11: ffff800009503180 x10: 0000000000000a80 x9 : ffff8000099b3d= 20 > [ 2.838879] x8 : ffff8000099c29a0 x7 : 00000000000000c0 x6 : > ffff000002838028 [ 2.846029] x5 : 0000000000000002 x4 : 00000000000000= 00 > x3 : 0000000000000000 [ 2.849626] imx-scu system-controller: RPC send > msg timeout > [ 2.853178] x2 : ffff800009c88060 x1 : 0000000000000001 x0 : > ffff0000033f4080 [ 2.858764] enet1: failed to power off resource 252 > ret -110 > [ 2.865897] Call trace: > [ 2.865901] lpi2c_imx_write_txfifo+0x44/0xb0 > [ 2.878443] __handle_irq_event_percpu+0x5c/0x188 > [ 2.883151] handle_irq_event+0x48/0xb0 > = > $ ./scripts/faddr2line build_arm64/vmlinux lpi2c_imx_write_txfifo+0x44/0x= b0 > lpi2c_imx_write_txfifo+0x44/0xb0: > lpi2c_imx_write_txfifo at drivers/i2c/busses/i2c-imx-lpi2c.c:364 > = > This now clearly pinpoints the wrong access which previously corrupted the > stack. The error leading to this wrong access is addressed in the > following patch. > = > drivers/i2c/busses/i2c-imx-lpi2c.c | 2 ++ > 1 file changed, 2 insertions(+) > = > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c > b/drivers/i2c/busses/i2c-imx-lpi2c.c index 188f2a36d2fd..c6d0225246e6 > 100644 > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c > @@ -463,6 +463,8 @@ static int lpi2c_imx_xfer(struct i2c_adapter *adapter, > if (num =3D=3D 1 && msgs[0].len =3D=3D 0) > goto stop; > = > + lpi2c_imx->rx_buf =3D NULL; > + lpi2c_imx->tx_buf =3D NULL; > lpi2c_imx->delivered =3D 0; > lpi2c_imx->msglen =3D msgs[i].len; > init_completion(&lpi2c_imx->complete); -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel