All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Aaron Conole <aconole@redhat.com>
Cc: dev@dpdk.org, Michael Santana Francisco <msantana@redhat.com>,
	David Marchand <dmarchan@redhat.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] ci: enable unit tests under travis-ci
Date: Fri, 02 Aug 2019 22:27:31 +0200	[thread overview]
Message-ID: <2139994.LeHafPJYVc@xps> (raw)
In-Reply-To: <CABzctQ9i9xrG-w4nKefoqbPvOhiO+CWAuHs6njSph-EhwixU4w@mail.gmail.com>

31/07/2019 22:54, Michael Santana Francisco:
> On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole <aconole@redhat.com> wrote:
> > --- a/.ci/linux-build.sh
> > +++ b/.ci/linux-build.sh
> > @@ -22,3 +22,11 @@ fi
> >  OPTS="$OPTS --default-library=$DEF_LIB"
> >  meson build --werror -Dexamples=all $OPTS
> >  ninja -C build
> > +
> > +if [ "$RUN_TESTS" = "1" ]; then
> > +    # On the test build, also build the documentation, since it's expensive
> > +    # and we shouldn't need to build so much of it.
> > +    ninja -C build doc

I am not sure to understand the comment.
Do you mean you build the documentation only once,
which is when running tests?
Why it is not a new option similar as RUN_TESTS?

> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -30,6 +30,7 @@ env:
> >    - DEF_LIB="shared"
> >    - DEF_LIB="static" OPTS="-Denable_kmods=false"
> >    - DEF_LIB="shared" OPTS="-Denable_kmods=false"
> > +  - DEF_LIB="shared" RUN_TESTS=1
> I don't agree with this. This is redundant. Why not put RUN_TESTS=1 on
> an already exiting builds instead of adding two new builds like you
> are doing here?

I agree it is a strange logic.
Why not use an existing build to run the tests?



  parent reply	other threads:[~2019-08-02 20:27 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 14:50 [dpdk-dev] [PATCH 0/2] Enable fast-unit tests under travis Aaron Conole
2019-07-31 14:50 ` [dpdk-dev] [PATCH 1/2] tests: Fix unit tests for shared builds Aaron Conole
2019-07-31 15:36   ` Bruce Richardson
2019-07-31 16:07     ` Aaron Conole
2019-07-31 16:10       ` Aaron Conole
2019-08-01  9:19         ` Bruce Richardson
2019-08-01 15:40           ` Aaron Conole
2019-08-01 16:51             ` Bruce Richardson
2019-08-01 16:52   ` Bruce Richardson
2019-08-02 20:32   ` Thomas Monjalon
2019-08-02 20:43     ` Aaron Conole
2019-07-31 14:50 ` [dpdk-dev] [PATCH 2/2] ci: enable unit tests under travis-ci Aaron Conole
2019-07-31 20:54   ` Michael Santana Francisco
2019-08-02 13:34     ` Aaron Conole
2019-08-02 13:40       ` Michael Santana Francisco
2019-08-02 20:27     ` Thomas Monjalon [this message]
2019-08-02 20:59       ` Aaron Conole
2019-08-02 21:05         ` Thomas Monjalon
2019-08-02 21:07           ` Aaron Conole
2019-08-02 14:18 ` [dpdk-dev] [PATCH 0/2] Enable fast-unit tests under travis David Marchand
2019-08-02 21:25 ` [dpdk-dev] [PATCH v2 " Aaron Conole
2019-08-02 21:25   ` [dpdk-dev] [PATCH v2 1/2] tests: Fix unit tests for shared builds Aaron Conole
2019-08-02 21:51     ` Thomas Monjalon
2019-08-02 21:25   ` [dpdk-dev] [PATCH v2 2/2] ci: enable unit tests under travis-ci Aaron Conole
2019-08-02 22:00   ` [dpdk-dev] [PATCH v2 0/2] Enable fast-unit tests under travis Thomas Monjalon
2019-08-05  6:26     ` David Marchand
2019-08-05 12:52       ` David Marchand
2019-08-05 13:56         ` Michael Santana Francisco
2019-08-05 14:18           ` Aaron Conole
2019-08-05 14:21             ` Thomas Monjalon
2019-08-07 14:06       ` Michael Santana Francisco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2139994.LeHafPJYVc@xps \
    --to=thomas@monjalon.net \
    --cc=aconole@redhat.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmarchan@redhat.com \
    --cc=ferruh.yigit@intel.com \
    --cc=msantana@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.