From: Thomas Monjalon <thomas@monjalon.net>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org, vipin.varghese@intel.com
Subject: Re: [PATCH v5 2/4] eal: add function to release internal resources
Date: Mon, 29 Jan 2018 19:20:14 +0100 [thread overview]
Message-ID: <2141791.M0NvFpFgTI@xps> (raw)
In-Reply-To: <1517243852-34142-2-git-send-email-harry.van.haaren@intel.com>
29/01/2018 17:37, Harry van Haaren:
> @@ -79,6 +80,10 @@ rte_exit(int exit_code, const char *format, ...)
> va_end(ap);
>
> #ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR
> + int ret = rte_eal_cleanup();
You should not declare a variable in the middle of the function.
Will fix on apply.
> + if (ret)
> + RTE_LOG(CRIT, EAL,
> + "EAL could not release all resources, code %d\n", ret);
> exit(exit_code);
> #else
> rte_dump_stack();
next prev parent reply other threads:[~2018-01-29 18:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 18:31 [PATCH 1/4] service: move finalize to internal Harry van Haaren
2018-01-27 18:31 ` [PATCH 2/4] eal: add function to release internal resources Harry van Haaren
2018-01-27 18:31 ` [PATCH 3/4] app/pdump: call eal finalize before exit Harry van Haaren
2018-01-27 18:31 ` [PATCH 4/4] app/proc_info: " Harry van Haaren
2018-01-29 10:45 ` [PATCH v2 1/4] service: move finalize to internal Harry van Haaren
2018-01-29 10:45 ` [PATCH v2 2/4] eal: add function to release internal resources Harry van Haaren
2018-01-29 10:55 ` Thomas Monjalon
2018-01-29 11:10 ` Van Haaren, Harry
2018-01-29 11:55 ` Thomas Monjalon
2018-01-29 12:04 ` Bruce Richardson
2018-01-29 12:12 ` Van Haaren, Harry
2018-01-29 10:45 ` [PATCH v2 3/4] app/pdump: call eal finalize before exit Harry van Haaren
2018-01-29 10:45 ` [PATCH v2 4/4] app/proc_info: " Harry van Haaren
2018-01-29 12:08 ` [PATCH v3 1/4] service: move finalize to internal Harry van Haaren
2018-01-29 12:08 ` [PATCH v3 2/4] eal: add function to release internal resources Harry van Haaren
2018-01-29 15:07 ` Varghese, Vipin
2018-01-29 12:08 ` [PATCH v3 3/4] app/pdump: call eal cleanup before exit Harry van Haaren
2018-01-29 15:09 ` Varghese, Vipin
2018-01-29 12:08 ` [PATCH v3 4/4] app/proc_info: " Harry van Haaren
2018-01-29 15:09 ` Varghese, Vipin
2018-01-29 15:05 ` [PATCH v3 1/4] service: move finalize to internal Varghese, Vipin
2018-01-29 16:00 ` [PATCH v4 " Harry van Haaren
2018-01-29 16:00 ` [PATCH v4 2/4] eal: add function to release internal resources Harry van Haaren
2018-01-29 16:00 ` [PATCH v4 3/4] app/pdump: call eal cleanup before exit Harry van Haaren
2018-01-29 16:00 ` [PATCH v4 4/4] app/proc_info: " Harry van Haaren
2018-01-29 16:37 ` [PATCH v5 1/4] service: move finalize to internal Harry van Haaren
2018-01-29 16:37 ` [PATCH v5 2/4] eal: add function to release internal resources Harry van Haaren
2018-01-29 18:20 ` Thomas Monjalon [this message]
2018-01-29 16:37 ` [PATCH v5 3/4] app/pdump: call eal cleanup before exit Harry van Haaren
2018-01-29 16:37 ` [PATCH v5 4/4] app/proc_info: " Harry van Haaren
2018-01-29 18:28 ` [PATCH v5 1/4] service: move finalize to internal Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2141791.M0NvFpFgTI@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.