From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH] qemu-xen-trad: free all the pirqs for msi/msix when driver unloads Date: Wed, 2 Jul 2014 16:06:46 +0100 Message-ID: <21428.8198.371406.754367@mariner.uk.xensource.com> References: <1396975483-31442-1-git-send-email-konrad.wilk@oracle.com> <1396975483-31442-2-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X2M7W-0002ZU-EA for xen-devel@lists.xenproject.org; Wed, 02 Jul 2014 15:06:50 +0000 In-Reply-To: <1396975483-31442-2-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, zhenzhong.duan@oracle.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Konrad Rzeszutek Wilk writes ("[Xen-devel] [PATCH] qemu-xen-trad: free all the pirqs for msi/msix when driver unloads"): > From: Zhenzhong Duan > > Pirqs are not freed when driver unloads, then new pirqs are allocated when > driver reloads. This could exhaust pirqs if do it in a loop. > > This patch fixes the bug by freeing pirqs when ENABLE bit is cleared in > msi/msix control reg. I have backported this to 4.4 and 4.3. It did not apply cleanly to 4.2 (and I have not investgated why). Thanks, Ian.