From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E993C43333 for ; Wed, 3 Mar 2021 11:26:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 575CB64F02 for ; Wed, 3 Mar 2021 11:26:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345418AbhCCLXp (ORCPT ); Wed, 3 Mar 2021 06:23:45 -0500 Received: from outbound-gw.openxchange.ahost.me ([94.136.40.163]:48032 "EHLO outbound-gw.openxchange.ahost.me" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237904AbhCCCKL (ORCPT ); Tue, 2 Mar 2021 21:10:11 -0500 Received: from localhost ([127.0.0.1] helo=outbound-gw.openxchange.ahost.me) by outbound-gw.openxchange.ahost.me with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384 (Exim 4.94) (envelope-from ) id 1lHFqc-0003v1-QL; Wed, 03 Mar 2021 00:58:42 +0000 Date: Wed, 3 Mar 2021 00:58:38 +0000 (GMT) From: Phillip Lougher To: Andrew Morton Cc: "linux-kernel@vger.kernel.org" Message-ID: <2145953354.2456187.1614733122707@webmail.123-reg.co.uk> In-Reply-To: <20210302163440.730a51442f9ce87d728c9ffd@linux-foundation.org> References: <2069685113.2081245.1614583677427@webmail.123-reg.co.uk> <20210302163440.730a51442f9ce87d728c9ffd@linux-foundation.org> Subject: Re: [PATCH] Squashfs: fix xattr id and id lookup sanity checks MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.3-Rev22 X-Originating-IP: 82.69.79.175 X-Originating-Client: com.openexchange.ox.gui.dhtml Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 03/03/2021 00:34 Andrew Morton wrote: > > > On Mon, 1 Mar 2021 07:27:57 +0000 (GMT) Phillip Lougher wrote: > > > The checks for maximum metadata block size is > > missing SQUASHFS_BLOCK_OFFSET (the two byte length > > count). > > What are the user visible consequences of this bug? The user will be unable to mount the filesystem, because it will fail the sanity check. > > > Cc: stable@vger.kernel.org > > Signed-off-by: Phillip Lougher > > Fixes: f37aa4c7366e23f ("squashfs: add more sanity checks in id lookup") > > yes? Yes. Phillip