From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753836AbdDCPpf (ORCPT ); Mon, 3 Apr 2017 11:45:35 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:59018 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753046AbdDCPpU (ORCPT ); Mon, 3 Apr 2017 11:45:20 -0400 Subject: Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table To: Lee Jones References: <20170401071854.23198-1-javier@osg.samsung.com> <20170401071854.23198-3-javier@osg.samsung.com> <20170403111502.lotjpd746vkhekkg@dell> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring From: Javier Martinez Canillas Message-ID: <2147b8c9-02ee-1b9c-a74e-119b0b73d1d7@osg.samsung.com> Date: Mon, 3 Apr 2017 11:45:14 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170403111502.lotjpd746vkhekkg@dell> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Lee, On 04/03/2017 07:15 AM, Lee Jones wrote: [snip] >> >> +static const struct of_device_id retu_of_match[] = { >> + { .compatible = "nokia,retu-mfd" }, >> + { .compatible = "nokia,tahvo-mfd" }, > > Please drop the "-mfd". > Yes, I also didn't like it but I didn't want to change it since that would mean that backward compatiblity and bisect-ability will be broken by this change. In other words, just adding a vendor prefix won't cause an issue if patches are merged independently since if DTS patches are merged before, the driver will still lookup using the I2C device ID table. And if the drivers patches are picked before, the DTS will match using the OF device ID table. But changing to "nokia,retu" and "nokia,tahvo" means that you will need to pick all patches and also that the DTS and drivers changes will have to be done in the same patch. If you are OK with that, then I can change in the next version. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America