From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] crypto: arm: workaround for building with old binutils Date: Sat, 11 Apr 2015 10:55:35 +0200 Message-ID: <2148670.W34n3asXfA@wuerfel> References: <3461827.FYLMCAIQyv@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Herbert Xu , "linux-kernel@vger.kernel.org" , Russell King , "linux-crypto@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "David S. Miller" To: Ard Biesheuvel Return-path: Received: from mout.kundenserver.de ([212.227.126.131]:56595 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932425AbbDKI4C (ORCPT ); Sat, 11 Apr 2015 04:56:02 -0400 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Saturday 11 April 2015 09:41:08 Ard Biesheuvel wrote: > Could you perhaps put the rules that build these modules inside a > > ifneq ($(armv8-ce-flags),-DARMV8_CE_DISABLED) > ... > endif > How about something like this: ifeq ($(call as-option,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),) $(warning ARMv8 Crypto Extensions need binutils 2.23 or higher) else ... endif That would basically be a reimplementation of the missing "as-option-yn" macro though, so we could also add that instead and do ifeq ($(call as-option-yn,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),y) $(warning ARMv8 Crypto Extensions need binutils 2.23 or higher) else ... endif Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933026AbbDKI4G (ORCPT ); Sat, 11 Apr 2015 04:56:06 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:56595 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932425AbbDKI4C (ORCPT ); Sat, 11 Apr 2015 04:56:02 -0400 From: Arnd Bergmann To: Ard Biesheuvel Cc: Herbert Xu , "linux-kernel@vger.kernel.org" , Russell King , "linux-crypto@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "David S. Miller" Subject: Re: [PATCH] crypto: arm: workaround for building with old binutils Date: Sat, 11 Apr 2015 10:55:35 +0200 Message-ID: <2148670.W34n3asXfA@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <3461827.FYLMCAIQyv@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:+L6dHsTr+FyrVutB1DQHOiQluAKFbbsluJgxjgJpVHLyx3uTtRY nyyMe7AyLHWfzfvxTQh3XBOyTKP1s7uYEmdz7dFFxkmiYhXc6UvLIw6y+SeRuTVtp1AiYUY m119Q+8RE8sCb60FPgiKpNCa7vaqKnH9j0ewONJMxBRwhfSNbtFSCLNsRQzK9TqjbZvmrQ6 JTi1xoZTVvVVtRnbx2pGA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 11 April 2015 09:41:08 Ard Biesheuvel wrote: > Could you perhaps put the rules that build these modules inside a > > ifneq ($(armv8-ce-flags),-DARMV8_CE_DISABLED) > ... > endif > How about something like this: ifeq ($(call as-option,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),) $(warning ARMv8 Crypto Extensions need binutils 2.23 or higher) else ... endif That would basically be a reimplementation of the missing "as-option-yn" macro though, so we could also add that instead and do ifeq ($(call as-option-yn,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),y) $(warning ARMv8 Crypto Extensions need binutils 2.23 or higher) else ... endif Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Sat, 11 Apr 2015 10:55:35 +0200 Subject: [PATCH] crypto: arm: workaround for building with old binutils In-Reply-To: References: <3461827.FYLMCAIQyv@wuerfel> Message-ID: <2148670.W34n3asXfA@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday 11 April 2015 09:41:08 Ard Biesheuvel wrote: > Could you perhaps put the rules that build these modules inside a > > ifneq ($(armv8-ce-flags),-DARMV8_CE_DISABLED) > ... > endif > How about something like this: ifeq ($(call as-option,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),) $(warning ARMv8 Crypto Extensions need binutils 2.23 or higher) else ... endif That would basically be a reimplementation of the missing "as-option-yn" macro though, so we could also add that instead and do ifeq ($(call as-option-yn,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),y) $(warning ARMv8 Crypto Extensions need binutils 2.23 or higher) else ... endif Arnd