From mboxrd@z Thu Jan 1 00:00:00 1970 From: Egbert Eich Subject: Re: [PATCH 1/2] drm/ast: open key before detect chips Date: Wed, 10 Sep 2014 10:34:15 +0200 Message-ID: <21520.3335.840736.390559@linux-qknr.fritz.box> References: <1410322074-4427-1-git-send-email-yc_chen@aspeedtech.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTP id 81E2F89EA9 for ; Wed, 10 Sep 2014 01:34:38 -0700 (PDT) In-Reply-To: yc_chen@aspeedtech.com wrote on Wednesday, 10 September 2014 at 12:07:53 +0800 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Y.C. Chen" Cc: eich@suse.com, dri-devel@lists.freedesktop.org, airlied@redhat.com List-Id: dri-devel@lists.freedesktop.org Y.C. Chen writes: > From: "Y.C. Chen" > > Some config settings like 3rd TX chips will not get correctly > if the extended reg is protected > > Signed-off-by: Y.C. Chen > --- > drivers/gpu/drm/ast/ast_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c > index a2cc6be..b027e33 100644 > --- a/drivers/gpu/drm/ast/ast_main.c > +++ b/drivers/gpu/drm/ast/ast_main.c > @@ -67,6 +67,7 @@ static int ast_detect_chip(struct drm_device *dev) > { > struct ast_private *ast = dev->dev_private; > uint32_t data, jreg; > + ast_open_key(ast); > > if (dev->pdev->device == PCI_CHIP_AST1180) { > ast->chip = AST1100; > -- > 1.8.3.1 > Reviewed-by: Egbert Eich