From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH v6 for-4.5 4/5] xl: add 'trim' and 'split_string_into_pair' functions Date: Fri, 26 Sep 2014 16:53:44 +0100 Message-ID: <21541.35848.418399.624165@mariner.uk.xensource.com> References: <1411591685-25308-1-git-send-email-dave.scott@citrix.com> <1411591685-25308-5-git-send-email-dave.scott@citrix.com> <20140926100917.GD12753@zion.uk.xensource.com> <21541.35354.847047.887012@mariner.uk.xensource.com> <20140926155150.GC28628@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XXXq9-0002Lm-FP for xen-devel@lists.xenproject.org; Fri, 26 Sep 2014 15:53:49 +0000 In-Reply-To: <20140926155150.GC28628@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: xen-devel@lists.xenproject.org, David Scott , ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Wei Liu writes ("Re: [PATCH v6 for-4.5 4/5] xl: add 'trim' and 'split_string_into_pair' functions"): > On Fri, Sep 26, 2014 at 04:45:30PM +0100, Ian Jackson wrote: > > I disagree. I think in general a function that takes any kind of > > pointer should be assumed to require a non-NULL pointer. It should > > not carry out any kind of nullness check; it should just dereference > > the pointer (and consequently crash if it is NULL). ... > Fair enough. I don't really have strong preference on this kind of > issue. We just need to have an agreement on which route we take. Right. The rest of libxl follows the convention I describe above. So I think this aspect of Dave's patch is fine. Iabn.