From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1949955AbdDYUhZ (ORCPT ); Tue, 25 Apr 2017 16:37:25 -0400 Received: from mx142.netapp.com ([216.240.21.19]:42556 "EHLO mx142.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941359AbdDYUhP (ORCPT ); Tue, 25 Apr 2017 16:37:15 -0400 X-IronPort-AV: E=Sophos;i="5.37,251,1488873600"; d="scan'208";a="184745714" Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=Netapp.com; Subject: Re: [PATCH 1/1 linux-next] nfs: kmap can't fail To: Fabian Frederick , Trond Myklebust CC: , References: <20170425181033.1892-1-fabf@skynet.be> From: Anna Schumaker Message-ID: <2158af9c-96c7-c124-38c6-3779fbaf373b@Netapp.com> Date: Tue, 25 Apr 2017 16:37:08 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <20170425181033.1892-1-fabf@skynet.be> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [68.40.188.1] X-ClientProxiedBy: CY4PR08CA0078.namprd08.prod.outlook.com (10.171.251.171) To MWHPR06MB2480.namprd06.prod.outlook.com (10.168.248.16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 058e3800-a4bd-4204-6a00-08d48c1ada63 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:MWHPR06MB2480; X-Microsoft-Exchange-Diagnostics: 1;MWHPR06MB2480;3:t3CcBLBOexuNJcwRojErR+2OuFfSz85U6YZGh7Cxu3Jc2vLNdEB1KhDRSZOTsxtOHwyRgHSmsc1Qk2paoMzN6PApB4a4kkRcEXcZcdxP2qpm5I7Exbz5HXCzaYRFGiaIqqn/6EbMTI253JfN4v3FQoEXogpg0RrY7+Xj3D6OYwtHnMfN9LBDqbDCVx3q7ood07rI6cA3KEfN8sPfOa2y51aFMr/7ImuEgtCb8YT6cLL+lAMpoK3ybVtBdYtxiVuw2AviUF561XNAKZaZpTGX6Ruox1UisqEmGHujAQ31cWYHVL7/FrefEsu3BXltyciMM5BstPF9hjebQ0FmrzrnHg==;25:eyFntwAlSBo4WzbIjsBQZpyFf3IT6Wt5sA9hrqowuJHES/b5VwYJWgWTRFElFlEsXGhEqU5sVaq/OwgDx2lRsC2BN8whJek4hfFHS6aO6UBZyAKzjYx4t80EICfYFztSeRGIcoIa+X/Yt61L0Ec+tGiYcU83h6l4GCNDAkYyaY68IKbOdV+/NtD7+Qy9+GMA+6loG9po9o1CR3y+x9Ta+rF3Y7VmbE66bJQKCwOqL2QlnhNAa3v7K+mmzGz86VLoPjmxsp+dJgsqVI9s4N+PJecXVszune8xByGm1PWud+f2X62Y/KWpxy0u6wGa3A948UCUQzey7YGwWeK9IvMydOAuvefitLudDU3aLvnChOty/KDkXAYTqZLCHilJaypDusOT+tpuhJlhsRKyi2OCWmm9lIMTEPrFRq46de3+YX3jr4GSoKNULVAvQ4sFy6eLP2PZenl6XCosV94Y1M4gjg== X-Microsoft-Exchange-Diagnostics: 1;MWHPR06MB2480;31:ZDilUqQf002ZiHBx8fWrnTNxW46GFWkW7KvL0GrhJ7QIuZqHk+S0UU8RI/8dO3/X1mbFPVXSJQTJm/1XgM540cmjWCJAasFFpQwYGVIqGuRIuEOLzOgt8URaZaW/sXTyBcSV1oxAcHCIF6bhAEODNBboUNJJPFzh5BYt0gfSWjr/Zm4jxTK3shYhB00GAYYotXSHDIgV7lcvJ2+uvBLxW7G2XJn4EHMhbRtvp9tAxarMvkWrLSDFcFWJShjvwN/dbmrXU25f2+UJwXFLyvP7TQHunu8hnTqIFAu2DMdTPS4=;20:Np14qIv5q/PqnWCEIAZiOf1pm4fKL1NHbUDDn3x8Axur/pZ4Uaq5jPyumBxzFJJSwQFIvOr3a0V2MMrqltxuMApXm/jdDaJWpuPAvx4gNQFr4j4lVAmSgvqc0Sbj/SgUoYaQb1CEQl+es3WyDWT5z4kB4GkFiZgZyyAKlWdKPGYHf3juCZKL5eoWh+Qy5Z/QeR7Q3LZVYtw2flmklSGwhf9FmQ4psItVU17do0CVYQehbMFQCJcjlvF26DSxo0cMyMc6WIs8JP9DfLItwMrKrmY7vx7kkc40u2cXh8acm8H10J0X9uYTU+ygv2bahuwzw0oCBuIDthSg79Et3fj+/sJm0sSRXrRgcWpOa970mWpjsA7M9AtYww0mim4R0FqlSMgl7HuiNCyOk6p/701EWYWw7W1vHVzDd7oklzoJJybUNkHaX0NygK8MFE2hIyl6QYem4cj6Uh6bBXi6ikqErHhC+UlnvCVMorwv4buy9CPp4oA3kB7oa/QdD6md3FxS X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(235404470278024); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(6072148);SRVR:MWHPR06MB2480;BCL:0;PCL:0;RULEID:;SRVR:MWHPR06MB2480; X-Microsoft-Exchange-Diagnostics: 1;MWHPR06MB2480;4:sMQNLFlA+v2EqcwRIf4b1QU5l4yUued857vIXuaboxxWioVpLIbjrF7WxHoesvOTAKeMQEIA6aiVahBXyGew/n1rv7WvW943v/0wr8rZo6IyZb613AnFcIGDnFTwS8w4iFn4Ob5MtR+TpwWuEIyX6QuZGu+xJcmkegfVqaBq+RWmqLMyTkTOeqC8lpwnFUDQHIQrFcZmkRBL7EzSuy/qWE/LFYkJq4AMMi4vZgjRLxBO4gVz8XdDUbIx+jPTCm/oTFAL120ujQXDzLrdrZhHJLjfK3KtKoo0jEoAjFTmDfIW91ZvUUuVMGo5Ktrze4zrhtAUoQVUHQETUiIjspB8xme0aY1yDNQgJgAufjRxns3Ov045gRK47VgK1Aq3yVmyOLkz0MUhamCNBsdZCtJ0TiFPCth6BuoLKZ1j5RGxSjKbuXL1wGyHj4ivaulbRToWepK8e7Mb5WMDh1TVSsjv6x2ZnSUQ/fRXIbXBfE9qrN/FedGjWoi720TUAjNorUavKsuLEMrFdK8ymgM1WjEYOwrgaRhP0ftwoGk/rklPPqNrXIsmo30WpID8Uw5UO8uWBv7g/FS9jme0l4LvX5x8SxyiW0FTAzTmjhiq7TUwRdRr5vZp8cByTyJ1/nKtEr7oo4K7ANa9QlS13AxwAemECTgwj+WB6OgCJaIAiD/M8lJ6Tg1pHdwJFzI5wIzHqx2QII0Z8pCQEOaJX5R0RhRLhnJFpTeNpOsopPD6n4JzOv4bfcnSdiVmadryrXiOCW5bWy0+nLbwPKqNHjEEPJPItw== X-Forefront-PRVS: 0288CD37D9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39410400002)(39450400003)(39850400002)(39840400002)(39400400002)(24454002)(377454003)(2906002)(65826007)(3846002)(83506001)(230700001)(229853002)(33646002)(6116002)(23676002)(81166006)(53546009)(5660300001)(50466002)(189998001)(38730400002)(6506006)(8676002)(47776003)(64126003)(53416004)(6486002)(31686004)(42186005)(4326008)(4001350100001)(66066001)(305945005)(54906002)(25786009)(65956001)(53936002)(2950100002)(7736002)(6246003)(6512007)(76176999)(6666003)(86362001)(50986999)(54356999)(36756003)(31696002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR06MB2480;H:gouda.nowheycreamery.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjA2TUIyNDgwOzIzOlpyZVpnMHF1OHNFMDNXTlpsVVNCeWx6MUNE?= =?utf-8?B?RWdraWlRazRkZXV2ZmJ6SS9QaFRoUlBpdnJiV1JSeE00SmpEcVVZa3c1MDhi?= =?utf-8?B?ZWdVcnBFcXZSRldrc0k2R2pEU0hCMmdPVWNwWWVRdTZvLzRpYkhJUHFLd0ZO?= =?utf-8?B?KzhYQmp2eTZ3dXZjby93UzBTU3lwcW5STlpiMFBOYkRrQndCOFpEK0xuRVkv?= =?utf-8?B?WW44dEhQdy9ucGllak8zcGpxOCtwTWQxRzhVbGZwaEJka2lXVHBWbDh2aDc4?= =?utf-8?B?RU9DNGs1SXEwMFlFMVBPVFhteEc4aDlzc2UzVW1ka2JDcU04NTQ4NnkvMUZE?= =?utf-8?B?V3BUNHVzazFLZ29ralpyeFRnWCtRNjEzSmZRcXdLSHlwSXc5Y0NWaXlIOVRH?= =?utf-8?B?dzgzSE5xSlJxekFLRlFNNnQ5M1RLSEMySzhkYU5CS2NTbWFsQ1dKOVE4SDdZ?= =?utf-8?B?QjU1YVpRendKTnFXZEhVYWNDVDJQdG90TVJMemhyRFE2eFduYlNPYWhRUVU0?= =?utf-8?B?eC9OQmoxQkVDWmk5bkF4T1VIa2UyeGJDdmptUlJyRXIrTXlONExBdnhEOVZv?= =?utf-8?B?Z000YmgvWTlLR0dwYSs1Z2lNamphWW9qdWlXbVdTQktoZFhiRW1IbmNoekxQ?= =?utf-8?B?cWIzMWlWVEpGVU5uUGlmbGxER1c3eGtnOElzU3VqSzRacUQxaVFKeG56MUlW?= =?utf-8?B?ajJWSEwwUEV6elBDVS90OHRLeWhMMDMycE1IMTQyQnhzSGdqODZFZVhjc3lI?= =?utf-8?B?K3U5aDI1K3lYbjBpWEo4YjRsRGRlS1pzYVlpbDZwelZaSmU4cE1mRzVOcCti?= =?utf-8?B?OWxXWW1icDY0SGhqVFJmZDR2RzdpelVVN2xNRlRGQklCKzluZ2pXZTh5RlhQ?= =?utf-8?B?SlVORTd5eXRrSnVjTmxTekhDM1JHU0JVOVExMTBPcFloRDZUR2pwQ3Z2T1Az?= =?utf-8?B?RWdtTm12UklRcTdlblA3ZGkzUTJ3YzdvMEl0NXBvME9UblVTODdBTklTRG81?= =?utf-8?B?dXJsUW55REsxQnVkNmhQOGxtbzFiTmNJWStLWDVOL1l2WjJOSmhMYWtTTUdV?= =?utf-8?B?TUZ6M05vTkkvaG9BMFVEOVV3ZGJVdkNFOGtwKy9KZUNYK3FOKzkrNEs4bk9q?= =?utf-8?B?dWV4TFlsL1BnczJQdXhrd002U2k4WWE1WkljTk14N2djZm1MekNkN3c5VTcx?= =?utf-8?B?NXhheTZ4ZmM0dlJkTjFlYlorOUlyNnpOYnNXR0hsaU83TjY0c1JBSzFUaHl6?= =?utf-8?B?S0RsUGRoK1liTUNhOFMrVkJuZk5PQm5aT1NsRnlQS1c1Z0JJdllDQ1VFUGhC?= =?utf-8?B?SDJuYWNJRmQzc1hFeUt2Uk9ZOXlZU3lqUytiOGN6Y3k5T3BDU2hRMUpyUURw?= =?utf-8?B?YzBsVE1Va1JkNFUzUEVUYlZKM1B0a2JjamVmQlJBSDQ4V3ZmTlN3QlpiUWVJ?= =?utf-8?B?bWxFMmhrUnN6WmZEOCs2V3dHb3dFdEdVa0t5U2NBNm91R3V3STBmdkNlM2JR?= =?utf-8?B?TTJ6TkFLTnpJRzJMNTJxN2krMG5ibHU1UFJ5RS96Y2FuMXIzVVVRUy9uS3ly?= =?utf-8?B?dU9GSE94ZTdsQXRpS0RYR09SYjI0UU9hNFZJZWdaL01Bck9nNUtJWDFvM2Zw?= =?utf-8?B?czdRa1M2dzgvRFcza041SnRSN1VUNk9KSjBlOVFpY1p2UytJNzRvVVVrcDR2?= =?utf-8?Q?k001x/2pT6lHhS9WoJlo8gMlMDDlkTWe8EfPZi0?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR06MB2480;6:awpzYLF9YsP6tEb4EcH5XnFecYfTgAvS1UxSoCB74CXTURxTzEy0pnyB7rhliyqpLyYx2yv6q+N2LweN+l3JOsG+s1TvuP2dzTtZ1Bp/9JS/mbwe3F6/r5pSLmz8HWxsMd8TcVsQ272utb9ZuMACvE3gxbGsmaHQDBUoEnpY3lq/ZELfef4LtO8uUWo08rGfyApTOZt+T6mdWKp2xXnCWc/TdBDLFalYAbbKHNyBQDFTaye4znBzVyL5xByE7esflm9cNdYvMjgcKMBK663PTVUmd0zxC5MjGLHlo9upj9xAWYWNiYh/gMyojozEQcvo2HOFBzlTTNFBhHnpiEiRO8EGjlUi5pgr38iIMay5AQohhChTlS2QuBMszYBJzJy6r1CexeI2tor4PchiRVoEr5q4aB3xJvD8tKEr6TR02WLAoO6tujXTSUgbn3RNPua3KCEm1kcM7ukYrf+0Dr6X3ppASa6EjgkmprMxL3K5oH3ElYgbiPsiLQH7p/Fo6lxDCK3q/m/MCukF38Mh7+c/pA==;5:oFEwPfXG6r6oN5eUF45mZj6ajzBlte2Ln2XEwwk11/R9H98XBWekokdVPcsjPwuR1ORl5M3T5NXbbJIO+9JHFdb4NUePPamSC2l0PWfy/9UR9hXf13Gi83Il6mQo2a4pRuvQ4MvfLQPk6YFaEaJhOg==;24:X1T+s4ktr8lwHK4ZzcGda2GE+m+A4VgITsuwFPrMQSTIf/waHPLKUtAfL7VNe2KPKrsePNC8EXu7F6TzB4OWF8b2+73qrbMa/u4wKPFv4Ik= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR06MB2480;7:uku13mSSjwTWsKekC7xlPXboPGZJRe03Vu+rAMzu+Jpwi5EyMULVGBbtw9/n3zZ1GpsiZAqEiHgicuv9e7tLvg3BJjgMZgIPURN9/7OM+TSa6stuueJs/e742fgqGGQg85aPYhs7KXL10FrsKqd22KQ5qNvRDNptIUxmjZ8a6f/AD5u+MVjWsr9OHH6pt3SfyCm6QD74aNWoaLWaOd41a6ZtIsFgFP4p9EGuxDJru2A84MBkQJJ7vMkIZ14110YjLobTncdHhXpBa/EAoCfeCe020tTs4VPPhb+dQ6sVepNB4oVhVywJCJ9ycTwAA+pxvz+qXMewU4sm7ZJUChe0/w== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2017 20:37:12.2755 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR06MB2480 X-OriginatorOrg: netapp.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fabian, On 04/25/2017 02:10 PM, Fabian Frederick wrote: > Remove NULL test on kmap() > > Signed-off-by: Fabian Frederick > --- > fs/nfs/dir.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c > index 3a188cb..f89e54c 100644 > --- a/fs/nfs/dir.c > +++ b/fs/nfs/dir.c > @@ -179,8 +179,6 @@ struct nfs_cache_array *nfs_readdir_get_array(struct page *page) > if (page == NULL) > return ERR_PTR(-EIO); > ptr = kmap(page); > - if (ptr == NULL) > - return ERR_PTR(-ENOMEM);> return ptr; While you're at it, can you remove the ptr variable entirely and change the code to "return kmap(page)" instead? Thanks, Anna > } > >