From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 4/4] eal: fix end character check in
	--lcores argument
Date: Tue, 02 Aug 2016 12:45:03 +0200
Message-ID: <2159818.VL9DW13Vyd@xps13>
References: <1469081018-55300-1-git-send-email-wei.dai@intel.com>
 <1717702.2SVR8RdYDI@xps13>
 <49759EB36A64CF4892C1AFEC9231E8D63A268522@PGSMSX106.gar.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "adambynes@outlook.com" <adambynes@outlook.com>, "Liang,
 Cunming" <cunming.liang@intel.com>
To: "Dai, Wei" <wei.dai@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 58A84FE5
 for <dev@dpdk.org>; Tue,  2 Aug 2016 12:45:06 +0200 (CEST)
Received: by mail-wm0-f48.google.com with SMTP id i5so283613000wmg.0
 for <dev@dpdk.org>; Tue, 02 Aug 2016 03:45:06 -0700 (PDT)
In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A268522@PGSMSX106.gar.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-08-02 08:22, Dai, Wei:
> Hi, Thomas, Yigit
> 
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2016-07-28 16:26, Ferruh Yigit:
> > > On 7/27/2016 12:27 PM, Wei Dai wrote:
> > > > With --lcores 'a-b@c-d', eal_parse_cores() fails because
> > > > eal_parse_set() fails due to the next character after lcore set a-b,
> > > > which is '@'and not ',' or '\0'.
> > > > There is also a right check immediately after this incorrect check.
> > > >
> > > > Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment")
> > > >
> > > > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > >
> > > I am not sure if a-b@c-d syntax should be supported. (a-b)@(c-d) is
> > > supported and already working.
> > 
> > Agreed.
> > 
> > Series applied, except this last patch 4, thanks
> 
> Sorry, I can't find any document to clarify whether a-b@c-d shoule be supported.
> So I design following case to verify all kinds of combination of - and @. 
> I tested my patch with --lcores '0-3@12-15, 4-7@(8-11),  (8-11)@4-7, (12-15)@(0-3), 16-19, (20-23) ',

OK. So do you agree we can discard this patch and forget this syntax?