From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940194AbdEXMz3 convert rfc822-to-8bit (ORCPT ); Wed, 24 May 2017 08:55:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53970 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933737AbdEXMx5 (ORCPT ); Wed, 24 May 2017 08:53:57 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A385CC04B94F Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A385CC04B94F Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170516221333.177280-1-mka@chromium.org> References: <20170516221333.177280-1-mka@chromium.org> To: Matthias Kaehlcke Cc: dhowells@redhat.com, Guenter Roeck , Andrew Morton , Sudip Mukherjee , linux-kernel@vger.kernel.org Subject: Re: [PATCH] frv: Declare jiffies to be located in the .data section MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <21626.1495630434.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Wed, 24 May 2017 13:53:54 +0100 Message-ID: <21627.1495630434@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 24 May 2017 12:53:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthias Kaehlcke wrote: > Commit 7c30f352c852 ("jiffies.h: declare jiffies and jiffies_64 with > ____cacheline_aligned_in_smp") removed a section specification from the > jiffies declaration that caused conflicts on some platforms. Unfortunately > this change broke the build for frv: > > kernel/built-in.o: In function `__do_softirq': > (.text+0x6460): relocation truncated to fit: R_FRV_GPREL12 against symbol > `jiffies' defined in *ABS* section in .tmp_vmlinux1 > kernel/built-in.o: In function `__do_softirq': > (.text+0x6574): relocation truncated to fit: R_FRV_GPREL12 against symbol > `jiffies' defined in *ABS* section in .tmp_vmlinux1 > kernel/built-in.o: In function `pwq_activate_delayed_work': > workqueue.c:(.text+0x15b9c): relocation truncated to fit: R_FRV_GPREL12 against > symbol `jiffies' defined in *ABS* section in .tmp_vmlinux1 > ... > > Add __jiffy_arch_data to the declaration of jiffies and use it on frv to > include the section specification. For all other platforms __jiffy_arch_data > (currently) has no effect. > > Fixes: 7c30f352c852 ("jiffies.h: declare jiffies and jiffies_64 with > ____cacheline_aligned_in_smp") > Signed-off-by: Matthias Kaehlcke Reviewed-by: David Howells