From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 1/8] net/mvneta: add neta PMD skeleton
Date: Mon, 24 Sep 2018 10:38:58 +0100
Message-ID: <2163b301-a8e1-14cc-c248-d700370460a8@intel.com>
References: <1537369294-17099-1-git-send-email-amo@semihalf.com>
 <1537434339-22570-1-git-send-email-amo@semihalf.com>
 <1537434339-22570-2-git-send-email-amo@semihalf.com>
 <7bb2d295-11dc-fabe-c982-e27688db1327@intel.com>
 <a81c6a28-9142-3aa4-0440-9af62e80b55e@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: mw@semihalf.com, zr@semihalf.com, tdu@semihalf.com, nadavh@marvell.com
To: Andrzej Ostruszka <amo@semihalf.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 4B0F81AFF
 for <dev@dpdk.org>; Mon, 24 Sep 2018 11:39:01 +0200 (CEST)
In-Reply-To: <a81c6a28-9142-3aa4-0440-9af62e80b55e@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/24/2018 10:35 AM, Ferruh Yigit wrote:
> On 9/24/2018 10:21 AM, Ferruh Yigit wrote:
>> On 9/20/2018 10:05 AM, Andrzej Ostruszka wrote:
>>> From: Zyta Szpak <zr@semihalf.com>
>>>
>>> Add neta pmd driver skeleton providing base for the further
>>> development.
>>>
>>> Signed-off-by: Natalie Samsonov <nsamsono@marvell.com>
>>> Signed-off-by: Yelena Krivosheev <yelena@marvell.com>
>>> Signed-off-by: Dmitri Epshtein <dima@marvell.com>
>>> Signed-off-by: Zyta Szpak <zr@semihalf.com>
>>> Signed-off-by: Andrzej Ostruszka <amo@semihalf.com>
>>
>> <...>
>>
>>> @@ -0,0 +1,75 @@
>>> +/* SPDX-License-Identifier: BSD-3-Clause
>>> + * Copyright(c) 2018 Marvell International Ltd.
>>> + * Copyright(c) 2018 Semihalf.
>>> + * All rights reserved.
>>> + */
>>> +
>>> +#ifndef _MVNETA_ETHDEV_H_
>>> +#define _MVNETA_ETHDEV_H_
>>> +
>>> +/*
>>> + * container_of is defined by both DPDK and MUSDK,
>>> + * we'll declare only one version.
>>> + *
>>> + * Note that it is not used in this PMD anyway.
>>> + */
>>> +#ifdef container_of
>>> +#undef container_of
>>> +#endif
>>> +
>>> +#include <drivers/mv_neta.h>
>>> +#include <drivers/mv_neta_ppio.h>
>>
>> Can't find mv_neta.h in $(LIBMUSDK_PATH)/include [1]
>>
>> There is a "mv_neta.h" in "./src/include/drivers/mv_neta.h" but not in the
>> installed path.
>> <musdk>/usr/local/include/drivers.
>>
>> Is there a specific build param required for musdk for neta support?
> 
> I found it: --enable-bpool-dma=64 --enable-pp2=no --enable-neta,

btw, getting "configure: WARNING: unrecognized options: --enable-bpool-dma"
FYI

> 
> But this means I need different musdk builds for mvpp2 and mvneta!
> Can't it possible to use single musdk build for both libraries?
> 
>>
>> [1]
>> .../drivers/net/mvneta/mvneta_ethdev.h:24:10: fatal error: 'drivers/mv_neta.h'
>> file not found
>> #include <drivers/mv_neta.h>
>>
>>          ^~~~~~~~~~~~~~~~~~~
>>
>