From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Harish Patil <harish.patil@qlogic.com>
Cc: dev@dpdk.org, Sony Chacko <sony.chacko@qlogic.com>
Subject: Re: [PATCH 2/5] bnx2x: Fix x86_64-native-linuxapp-clang build error
Date: Fri, 23 Oct 2015 18:42:31 +0200 [thread overview]
Message-ID: <2165749.fmlpNCHWa5@xps13> (raw)
In-Reply-To: <D24FAF13.D916A%harish.patil@qlogic.com>
2015-10-23 16:36, Harish Patil:
> >
> >2015-09-11 17:42, Rasesh Mody:
> >> #define SHMEM_EEE_ADV_STATUS_MASK 0x00f00000
> >> #define SHMEM_EEE_100M_ADV (1<<0)
> >> - #define SHMEM_EEE_1G_ADV (1<<1)
> >> + #define SHMEM_EEE_1G_ADV (1U<<1)
> >> #define SHMEM_EEE_10G_ADV (1<<2)
> >
> >Why other constants are not changed?
> I only addressed the build error which is against SHMEM_EEE_1G_ADV.
> Is that okay?
I would say no but you have the ownership on this code.
Please think which code quality you are expecting.
> This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
Please remove this footer, irrelevant on a mailing list.
next prev parent reply other threads:[~2015-10-23 16:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-12 0:42 [PATCH 0/5] bnx2x: Enhancement, fixes, licensing and doumentation Rasesh Mody
2015-09-12 0:42 ` [PATCH 1/5] bnx2x: SR-IOV VF driver changes to support OOB PF driver Rasesh Mody
2015-10-20 16:10 ` Thomas Monjalon
2015-10-21 15:24 ` Harish Patil
2015-10-21 15:34 ` Thomas Monjalon
2015-10-21 15:42 ` Harish Patil
2015-09-12 0:42 ` [PATCH 2/5] bnx2x: Fix x86_64-native-linuxapp-clang build error Rasesh Mody
2015-10-20 16:11 ` Thomas Monjalon
2015-10-23 16:36 ` Harish Patil
2015-10-23 16:42 ` Thomas Monjalon [this message]
2015-11-03 6:27 ` Harish Patil
2015-09-12 0:42 ` [PATCH 3/5] bnx2x: Add RTE_LIBRTE_BNX2X_REG_ACCESS config option Rasesh Mody
2015-10-20 16:18 ` Thomas Monjalon
2015-10-23 22:28 ` Harish Patil
2015-10-24 13:09 ` Thomas Monjalon
2015-11-07 3:08 ` Harish Patil
2015-11-07 21:53 ` Thomas Monjalon
2015-11-08 16:14 ` Harish Patil
2015-09-12 0:42 ` [PATCH 4/5] doc: Add BNX2X PMD documentation Rasesh Mody
2015-09-12 0:42 ` [PATCH 5/5] bnx2x: Add LICENSE.bnx2x_pmd and update source files Rasesh Mody
2015-09-12 1:17 ` [PATCH 0/5] bnx2x: Enhancement, fixes, licensing and doumentation Stephen Hemminger
2015-09-12 2:27 ` Harish Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2165749.fmlpNCHWa5@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.